[GitHub] peedeeboy opened a new pull request #1148: [NETBEANS-2182] Display correct licence (Oracle / Eclipse Foundation) depending on version of GlassFish to download

[GitBox <gi...@apache.org>]

peedeeboy opened a new pull request #1148: [NETBEANS-2182] Display correct licence (Oracle / Eclipse Foundation) depending on version of GlassFish to download
URL: https://github.com/apache/incubator-netbeans/pull/1148
 
 
   What this pull request does in a nutshell
   ---------------------------------------------
   Expands on #1141 by:
   
   - Removing the JOptionDialog to select a version of GlassFish to download, and moving that functionality to the JPanel in the Wizard
   - Amending the ServerDetails enums to include a URL to the appropriate license (Oracle / EF) for each GlassFish version supported
   - Button to open license now checks selected version of GlassFish and opens browser pointing to correct license from ServerDetails
   - Fixes a tiny typo in #1141 (typo was probably actually copied from my instructions in Jira!)
   
   
   API Changes
   --------------
   org.netbeans.modules.glassfish.common.ServerDetails now has a new public method, getLicenseUrl() that returns the URL for a given version of GlassFish
   
   I have incremented the API version number in the manifest file from 1.76 to 1.77.  Is there anything else I need to do?
   
   
   Alternative to API change
   ----------------------------
   If the API change is a bad thing, an alternative would be to add a couple of constants to the Glassfish Wizard, and if ServerDetails.getVersion() <= 500 then Oracle license, else Eclipse license.  That would feel hacky though, and one more random thing to miss when added support for a new version of GF.
   
   
   Testing
   --------
   - Launch NB, Services tab -> Servers -> Right click -> Add Server
   - Select GlassFish server -> Next
   - After PR: JComboBox is now on this panel.  Select a version of GF and click on the license link - correct license for the version of GlassFish selected should be displayed
   - Changing version of GlassFish selected, will uncheck the license checkbox
   
   
   Dependencies
   ----------------
   This is built on top of b141842 from #1141

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists