You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2018/02/02 07:52:33 UTC
Review Request 65477: Fix UI table layout issue on Config Summaries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/
-----------------------------------------------------------
Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
Diffs
-----
ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
Diff: https://reviews.apache.org/r/65477/diff/1/
Testing
-------
See screenshots.
File Attachments
----------------
before
https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
after
https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
Thanks,
David McLaughlin
Re: Review Request 65477: Fix UI table layout issue on Config
Summaries
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196715
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On Feb. 2, 2018, 7:52 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 7:52 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
>
>
> Diff: https://reviews.apache.org/r/65477/diff/1/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> before
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65477: Fix UI table layout issue on Config
Summaries
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196701
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Feb. 2, 2018, 8:52 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 8:52 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
>
>
> Diff: https://reviews.apache.org/r/65477/diff/1/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> before
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65477: Fix UI table layout issue on Config
Summaries
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196712
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Feb. 1, 2018, 11:52 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 11:52 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
>
>
> Diff: https://reviews.apache.org/r/65477/diff/1/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> before
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65477: Fix UI table layout issue on Config
Summaries
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196698
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Feb. 2, 2018, 8:52 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 8:52 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
>
>
> Diff: https://reviews.apache.org/r/65477/diff/1/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> before
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65477: Fix UI table layout issue on Config
Summaries
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196704
-----------------------------------------------------------
Master (21a371c) is red with this patch.
./build-support/jenkins/build.sh
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
--------------- Captured log call ----------------
health_checker.py 167 INFO INFO] Reached consecutive success limit.
health_checker.py 143 WARNING WARN] Health check failure: failure-2
health_checker.py 184 WARNING WARN] Ignoring failure of attempt: 2
health_checker.py 143 WARNING WARN] Health check failure: failure-3
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
5 failed, 795 passed, 6 skipped in 492.44 seconds
FAILURE
Waiting for background workers to finish.
10:22:57 08:50 [complete]
FAILURE
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2018, 3:52 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 3:52 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
>
>
> Diff: https://reviews.apache.org/r/65477/diff/1/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> before
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65477: Fix UI table layout issue on Config
Summaries
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196693
-----------------------------------------------------------
Master (21a371c) is red with this patch.
./build-support/jenkins/build.sh
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
--------------- Captured log call ----------------
health_checker.py 167 INFO INFO] Reached consecutive success limit.
health_checker.py 143 WARNING WARN] Health check failure: failure-2
health_checker.py 184 WARNING WARN] Ignoring failure of attempt: 2
health_checker.py 143 WARNING WARN] Health check failure: failure-3
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
1 failed, 799 passed, 6 skipped in 260.33 seconds
FAILURE
Waiting for background workers to finish.
08:06:46 04:55 [complete]
FAILURE
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2018, 3:52 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 3:52 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix UI table layout issue when configuration metadata (or any other cell) is longer than the max width of the table.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 2ae4e73c5d8d4e653cd1c550e699888b42554aec
>
>
> Diff: https://reviews.apache.org/r/65477/diff/1/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> before
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>