[GitHub] [pinot] walterddr commented on a diff in pull request #9760: [hotfix][multistage] fix error not returned issue

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9760:
URL: https://github.com/apache/pinot/pull/9760#discussion_r1016894483


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerExceptionTest.java:
##########
@@ -71,11 +71,11 @@ private Object[][] provideTestSqlWithExecutionException() {
         // Function with incorrect argument signature should throw runtime exception
         new Object[]{"SELECT least(a.col2, b.col3) FROM a JOIN b ON a.col1 = b.col1",
             "ArithmeticFunctions.least(double,double) with arguments"},
-        // Function that tries to cast String to Number should throw runtime exception
-        new Object[]{"SELECT a.col2, b.col1 FROM a JOIN b ON a.col1 = b.col3", "transform function: cast"},
+        // TODO: this error is thrown but not returned through mailbox. need another test for asserting failure

Review Comment:
   this maybe related to 2 issues @61yao filed: https://github.com/apache/pinot/issues/9671 and https://github.com/apache/pinot/issues/9723
   
   after queryplan is generated.
   1. QueryDispatcher dispatches the query stages to servers
       - b/c of this behavior, the query dispatch API referred to in #9671 (which is not async) doesn't need to be async since it return immediately after dispatch successful & the GRPC context return immediately after the query plan is valid.
       - however it also should assert initialization of the query plan has no exception, which is what is doesn't do, and what this TODO meant to fix.
   2. Server executes the query and returns data via mailboxes
       - once the query plan can be fully translate to an executable operator chain, any error occur during this will be returned by mailbox and it will bubble up eventually. this is what this PR is trying to fix.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org