You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Paul Rogers (JIRA)" <ji...@apache.org> on 2016/11/21 17:32:58 UTC
[jira] [Updated] (DRILL-5058) External sort does not handle its own
UserExceptions
[ https://issues.apache.org/jira/browse/DRILL-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Rogers updated DRILL-5058:
-------------------------------
Description:
The external sort throws a {{UserException}} in a variety of conditions: error during spilling, on out-of-memory on SV2 allocation, and on a schema change.
However, except for the schema change, the external sort does not *handle* the exceptions that it throws. In part this is because {{UserException}} is unchecked, so the code is not obligated to handle it. By handle, here we mean clean up resources, send a {{IterOutcome.STOP}} result to the downstream operator, etc.
The fix is to add a catch for {{UserException}} to the block of catches in {{innerNext()}}.
was:
The external sort throws a {{UserException}} in a variety of conditions: error during spilling, on out-of-memory on SV2 allocation, and on a schema change.
However, except for the schema change, the external sort does not *handle* the exceptions that it throws. In part this is because {{UserException}} is unchecked, so the code is not obligated to handle it.
The fix is to add a catch for {{UserException}} to the block of catches in {{innerNext()}}.
> External sort does not handle its own UserExceptions
> ----------------------------------------------------
>
> Key: DRILL-5058
> URL: https://issues.apache.org/jira/browse/DRILL-5058
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
>
> The external sort throws a {{UserException}} in a variety of conditions: error during spilling, on out-of-memory on SV2 allocation, and on a schema change.
> However, except for the schema change, the external sort does not *handle* the exceptions that it throws. In part this is because {{UserException}} is unchecked, so the code is not obligated to handle it. By handle, here we mean clean up resources, send a {{IterOutcome.STOP}} result to the downstream operator, etc.
> The fix is to add a catch for {{UserException}} to the block of catches in {{innerNext()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)