You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mo...@apache.org on 2009/05/07 15:11:48 UTC
svn commit: r772642 - in /ofbiz/trunk/applications/order:
data/OrderTypeData.xml script/org/ofbiz/order/order/OrderReturnServices.xml
servicedef/secas.xml servicedef/services_return.xml
Author: mor
Date: Thu May 7 13:11:48 2009
New Revision: 772642
URL: http://svn.apache.org/viewvc?rev=772642&view=rev
Log:
Added new return type "Replace Immediately". This could be used with returns for which items are not expected to be returned and even item(s) cost less then the shipping
charges.
Patch from Deepesh Kapoor (reviewed and tested by Pranay Pandey), part of OFBIZ-2428 (https://issues.apache.org/jira/browse/OFBIZ-2428)
Note: I have made only one change, changed the return type from RTN_REPLACEIMMEDIATE to RTN_REPLACE_IMMEDIAT just for sake of clarity.
Modified:
ofbiz/trunk/applications/order/data/OrderTypeData.xml
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml
ofbiz/trunk/applications/order/servicedef/secas.xml
ofbiz/trunk/applications/order/servicedef/services_return.xml
Modified: ofbiz/trunk/applications/order/data/OrderTypeData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/data/OrderTypeData.xml?rev=772642&r1=772641&r2=772642&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/data/OrderTypeData.xml (original)
+++ ofbiz/trunk/applications/order/data/OrderTypeData.xml Thu May 7 13:11:48 2009
@@ -329,6 +329,7 @@
<ReturnType sequenceId="04" returnTypeId="RTN_CSREPLACE" description="Cross-Ship Replacement"/>
<ReturnType sequenceId="05" returnTypeId="RTN_REPAIR_REPLACE" description="Repair Replacement"/>
<ReturnType sequenceId="06" returnTypeId="RTN_WAIT_REPLACE_RES" description="Wait Replacement Reserved"/>
+ <ReturnType sequenceId="07" returnTypeId="RTN_REPLACE_IMMEDIAT" description="Replace Immediately"/>
<WorkReqFulfType description="Implements" workReqFulfTypeId="WRF_IMPLEMENTS"/>
<WorkReqFulfType description="Fixes" workReqFulfTypeId="WRF_FIXES"/>
Modified: ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml?rev=772642&r1=772641&r2=772642&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml (original)
+++ ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml Thu May 7 13:11:48 2009
@@ -919,6 +919,12 @@
</if-compare>
</simple-method>
+ <simple-method method-name="processReplaceImmediatelyReturn" short-description="Process the replacements in a immediate return">
+ <set field="inMap.returnId" from-field="parameters.returnId"/>
+ <set field="inMap.returnTypeId" value="RTN_REPLACE_IMMEDIAT"/>
+ <call-service service-name="processReplacementReturn" in-map-name="inMap"/>
+ </simple-method>
+
<simple-method method-name="createReturnItemShipment" short-description="Create a ReturnItemShipment">
<check-permission permission="ORDERMGR" action="_CREATE"><fail-property resource="OrderErrorUiLabels" property="OrderSecurityErrorToRunCreateReturnItemShipment"/></check-permission>
<check-errors/>
Modified: ofbiz/trunk/applications/order/servicedef/secas.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/secas.xml?rev=772642&r1=772641&r2=772642&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/servicedef/secas.xml (original)
+++ ofbiz/trunk/applications/order/servicedef/secas.xml Thu May 7 13:11:48 2009
@@ -186,6 +186,7 @@
<condition field-name="statusId" operator="equals" value="RETURN_ACCEPTED"/>
<condition field-name="oldStatusId" operator="not-equals" value="RETURN_ACCEPTED"/>
<action service="processWaitReplacementReservedReturn" mode="sync"/>
+ <action service="processReplaceImmediatelyReturn" mode="sync"/>
<action service="createShipmentAndItemsForReturn" mode="sync"/>
<action service="processCrossShipReplacementReturn" mode="sync"/>
<action service="createTrackingCodeOrderReturns" mode="sync" run-as-user="system"/>
Modified: ofbiz/trunk/applications/order/servicedef/services_return.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services_return.xml?rev=772642&r1=772641&r2=772642&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/servicedef/services_return.xml (original)
+++ ofbiz/trunk/applications/order/servicedef/services_return.xml Thu May 7 13:11:48 2009
@@ -247,6 +247,11 @@
<description>Process the replacements in a repair return</description>
<attribute name="returnId" type="String" mode="IN" optional="false"/>
</service>
+ <service name="processReplaceImmediatelyReturn" engine="simple" auth="true"
+ location="component://order/script/org/ofbiz/order/order/OrderReturnServices.xml" invoke="processReplaceImmediatelyReturn">
+ <description>Process the replacements in a Immediate Return</description>
+ <attribute name="returnId" type="String" mode="IN" optional="false"/>
+ </service>
<service name="processSubscriptionReturn" engine="java" auth="true"
location="org.ofbiz.order.order.OrderReturnServices" invoke="processSubscriptionReturn">
<description>Process subscription changes from a return</description>