You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2020/01/20 18:21:01 UTC
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15072
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
The build script was modified to generate Kudu JARs and add them
to the Kudu tarball.
redhat6 and redhat7 docker images were modified to update Java 8
to a newer version that is suitable for building the Java
artifacts.
ubuntu1404 docker image was modified to include CA certificate
file for Java.
Testing:
Ran the C6 toolchain build job to verify that native-toolchain
builds on all supported platforms.
Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
---
M docker/all/postinstall.sh
A docker/redhat/Centos7-Vault.repo
M docker/redhat6.df
M docker/redhat7.df
M docker/ubuntu1404.df
M source/kudu/build.sh
6 files changed, 40 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/72/15072/1
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 2:
Took a first pass through it, it looks pretty good.
There is one issue that makes me wonder:
1.we explicitly include the C/C++ compiler version in the resulting tarballs' name
2. We now start including Java binaries in the same tarballs. Java binaries can (in theory at least, if not in current practice) be produced by different JDK versions,
so should we start including the JDK version (or distro+version) string in the artifact names?
Currently we build only with JDK 8, but as JDK 8 is nearing its End of Support Date, this may change one day.
We can also defer the decision and establish the convention that no explicit Java version means JDK 8, and everything else is marked; this can be left to our future selves.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jan 2020 22:11:07 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
The build script was modified to generate Kudu JARs and add them
to the Kudu tarball.
redhat6 and redhat7 docker images were modified to update Java 8
to a newer version that is suitable for building the Java
artifacts.
ubuntu1404 docker image was modified to include CA certificate
file for Java.
Testing:
Ran the C6 toolchain build job to verify that native-toolchain
builds on all supported platforms.
Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Reviewed-on: http://gerrit.cloudera.org:8080/15072
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Attila Jeges <at...@cloudera.com>
---
M docker/all/postinstall.sh
A docker/redhat/Centos7-Vault.repo
M docker/redhat6.df
M docker/redhat7.df
M docker/ubuntu1404.df
M source/kudu/build.sh
6 files changed, 45 insertions(+), 6 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Attila Jeges: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 2:
> > Took a first pass through it, it looks pretty good.
> > There is one issue that makes me wonder:
> > 1.we explicitly include the C/C++ compiler version in the
> resulting
> > tarballs' name
> > 2. We now start including Java binaries in the same tarballs.
> Java
> > binaries can (in theory at least, if not in current practice) be
> > produced by different JDK versions,
> > so should we start including the JDK version (or distro+version)
> > string in the artifact names?
> > Currently we build only with JDK 8, but as JDK 8 is nearing its
> End
> > of Support Date, this may change one day.
> > We can also defer the decision and establish the convention that
> no
> > explicit Java version means JDK 8, and everything else is marked;
> > this can be left to our future selves.
>
> Distro names are already included in the tarball names uploaded to
> the S3 bucket.
>
> I agree that JDK version should be added to the tarball names
> eventually. I'm not sure if we should do it now or as a separate
> change. Let's see what Joe thinks about it.
I think we can wait on adding the jdk version to the tarball name. We aren't at the point where we are compiling anything with something other than jdk 8, so we don't know what we will end up needing. Unless we gain something by being proactive, I think we can wait.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 18:45:10 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
The build script was modified to generate Kudu JARs and add them
to the Kudu tarball.
redhat6 and redhat7 docker images were modified to update Java 8
to a newer version that is suitable for building the Java
artifacts.
ubuntu1404 docker image was modified to include CA certificate
file for Java.
Testing:
Ran the C6 toolchain build job to verify that native-toolchain
builds on all supported platforms.
Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
---
M docker/all/postinstall.sh
A docker/redhat/Centos7-Vault.repo
M docker/redhat6.df
M docker/redhat7.df
M docker/ubuntu1404.df
M source/kudu/build.sh
6 files changed, 40 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/72/15072/2
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15072/3/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/15072/3/source/kudu/build.sh@137
PS3, Line 137: local JAVA_INSTALL_DIR="$LOCAL_INSTALL/java"
: mkdir -p "$JAVA_INSTALL_DIR"
: pushd java
: export GRADLE_USER_HOME="$(pwd)"
: wrap ./gradlew :kudu-hive:assemble :kudu-client:assemble
: # Copy kudu-hive jars to JAVA_INSTALL_DIR.
: local F
: for F in kudu-hive/build/libs/kudu-hive-*.jar; do
: cp "$F" "$JAVA_INSTALL_DIR"
: done
: # Install kudu-client artifacts to the Local Maven Repository:
: wrap ./gradlew -Dmaven.repo.local="${JAVA_INSTALL_DIR}/repository" :kudu-client:install
: popd
I've also tested Impala quickly with kudu-hive and kudu-client built like this locally on my dev machine.
It looks good, impala builds without an issue and the kudu-related E2E tests that I've tried passed.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 14:38:17 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 2:
(3 comments)
> (3 comments)
>
> I think the changes to the docker side make sense. I have a few
> small comments, but it sounds good.
>
> For the actual kudu build steps, I think we'll need to see what
> Impala needs from the Kudu java side to get this right. I left a
> comment about what I think we would need, but I don't think our
> progress needs to be blocked on everything being perfect. One way
> forward is that we put the Kudu java artifacts in a subdirectory
> (which we know will not conflict with the existing implementation)
> and then it becomes fairly harmless to check in something that is
> not perfect. Then, as we do the Impala change and find what we
> need, we do an additional change to get anything we missed. Another
> way forward is to merge the docker stuff (which lets us update the
> docker images) and then do the Kudu part in concert with the Impala
> change.
Thanks for the help. I decided to generate the Java artifacts and put them into a subdirectory in this patch-set.
I'll do a kudu version bump in a separate patch and finally change Impala to consume the generated Java artifacts in a third patch.
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat6.df
File docker/redhat6.df:
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat6.df@15
PS2, Line 15: # Install a newer java-1.8.0-openjdk-devel from centos:6.8.
: # The java-1.8.0-openjdk-devel version shipped with centos:6.6 is unable to handle ECDHE
: # ciphers.
: RUN yum-install --disablerepo='*' --enablerepo=C6.8-base java-1.8.0-openjdk-devel
> The way I think about this is that there are some libraries we use newer ve
Done
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat7.df
File docker/redhat7.df:
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat7.df@9
PS2, Line 9: # We get a newer java-1.8.0-openjdk-devel from centos:7.4.
: # The java-1.8.0-openjdk version shipped with centos:7.2 is unable to handle ECDHE
: # ciphers.
: RUN yum-install --disablerepo='*' --enablerepo=C7.4-base java-1.8.0-openjdk-devel
> Same as the redhat6.df comment, move this below the big install command.
Done
http://gerrit.cloudera.org:8080/#/c/15072/2/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/15072/2/source/kudu/build.sh@140
PS2, Line 140: wrap ./gradlew :kudu-hive:assemble
: for F in kudu-hive/build/libs/kudu-*.jar; do
: cp "$F" "$JAVA_INSTALL_DIR"
: done
> My thought on this part is that we are going to want to test it with the co
I've changed the code to put the kudu-hive jars and the kudu-client maven repo to $LOCAL_INSTALL/java. Done.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 25 Jan 2020 07:21:59 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
The build script was modified to generate Kudu JARs and add them
to the Kudu tarball.
redhat6 and redhat7 docker images were modified to update Java 8
to a newer version that is suitable for building the Java
artifacts.
ubuntu1404 docker image was modified to include CA certificate
file for Java.
Testing:
Ran the C6 toolchain build job to verify that native-toolchain
builds on all supported platforms.
Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
---
M docker/all/postinstall.sh
A docker/redhat/Centos7-Vault.repo
M docker/redhat6.df
M docker/redhat7.df
M docker/ubuntu1404.df
M source/kudu/build.sh
6 files changed, 45 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/72/15072/3
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 2:
> Took a first pass through it, it looks pretty good.
> There is one issue that makes me wonder:
> 1.we explicitly include the C/C++ compiler version in the resulting
> tarballs' name
> 2. We now start including Java binaries in the same tarballs. Java
> binaries can (in theory at least, if not in current practice) be
> produced by different JDK versions,
> so should we start including the JDK version (or distro+version)
> string in the artifact names?
> Currently we build only with JDK 8, but as JDK 8 is nearing its End
> of Support Date, this may change one day.
> We can also defer the decision and establish the convention that no
> explicit Java version means JDK 8, and everything else is marked;
> this can be left to our future selves.
Distro names are already included in the tarball names uploaded to the S3 bucket.
I agree that JDK version should be added to the tarball names eventually. I'm not sure if we should do it now or as a separate change. Let's see what Joe thinks about it.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 15:10:06 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 2:
(3 comments)
I think the changes to the docker side make sense. I have a few small comments, but it sounds good.
For the actual kudu build steps, I think we'll need to see what Impala needs from the Kudu java side to get this right. I left a comment about what I think we would need, but I don't think our progress needs to be blocked on everything being perfect. One way forward is that we put the Kudu java artifacts in a subdirectory (which we know will not conflict with the existing implementation) and then it becomes fairly harmless to check in something that is not perfect. Then, as we do the Impala change and find what we need, we do an additional change to get anything we missed. Another way forward is to merge the docker stuff (which lets us update the docker images) and then do the Kudu part in concert with the Impala change.
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat6.df
File docker/redhat6.df:
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat6.df@15
PS2, Line 15: # Install a newer java-1.8.0-openjdk-devel from centos:6.8.
: # The java-1.8.0-openjdk-devel version shipped with centos:6.6 is unable to handle ECDHE
: # ciphers.
: RUN yum-install --disablerepo='*' --enablerepo=C6.8-base java-1.8.0-openjdk-devel
The way I think about this is that there are some libraries we use newer versions for because we need that to even run yum (or apt or whatever). Those obviously get installed before the normal command, because we have no choice.
For openjdk, we have the choice of installing it before or after the command below that installs everything else. Either could potentially work. I prefer to install the newer openjdk after the command that installs everything else. That means that we use as much from the older repo as possible, because the packages below will get all their dependencies from the old repo.
So, please move this below the big install command. Let me know if that starts to fail.
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat7.df
File docker/redhat7.df:
http://gerrit.cloudera.org:8080/#/c/15072/2/docker/redhat7.df@9
PS2, Line 9: # We get a newer java-1.8.0-openjdk-devel from centos:7.4.
: # The java-1.8.0-openjdk version shipped with centos:7.2 is unable to handle ECDHE
: # ciphers.
: RUN yum-install --disablerepo='*' --enablerepo=C7.4-base java-1.8.0-openjdk-devel
Same as the redhat6.df comment, move this below the big install command.
http://gerrit.cloudera.org:8080/#/c/15072/2/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/15072/2/source/kudu/build.sh@140
PS2, Line 140: wrap ./gradlew :kudu-hive:assemble
: for F in kudu-hive/build/libs/kudu-*.jar; do
: cp "$F" "$JAVA_INSTALL_DIR"
: done
My thought on this part is that we are going to want to test it with the corresponding Impala change.
My understanding is that there are two parts we need from the Kudu side. The first is the kudu-hive jars, which we use for the hms integration. I think those are mainly needed for tests. The second is the kudu client dependency for frontend compilation:
https://github.com/apache/impala/blob/master/fe/pom.xml#L390-L394
For that, we need a valid maven repository that we can use to get the kudu client (and potentially its dependencies).
So, here are some comments for now:
- Impala is going to want the kudu-client in a valid maven repository, which has a particular structure. Look in your ~/.m2 directory to see the structure. We'll want a command that generates that structure.
- I think we will want these jars/maven repo to be in a subdirectory of $LOCAL_INSTALL. Right now, we have $LOCAL_INSTALL/debug and $LOCAL_INSTALL/release. Maybe we should put the java artifacts / maven repo in a $LOCAL_INSTALL/java directory (or even separate directories for kudu-hive vs the maven repo). We will be able to set the IMPALA_KUDU_JAVA_HOME variable to this directory.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 18:35:31 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 14:51:30 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts
......................................................................
Patch Set 3: Code-Review+2
This looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/15072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af
Gerrit-Change-Number: 15072
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 00:27:44 +0000
Gerrit-HasComments: No