[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634283#comment-17634283 ] 

ASF subversion and git services commented on OFBIZ-12126:
---------------------------------------------------------

Commit 68c1084edc56872fe7621976fd5d88bc1312b180 in ofbiz-framework's branch refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=68c1084edc ]

Improved: MacroFormRenderer refactoring of datetime fields (OFBIZ-12126)

Part of the OFBIZ-11456 MacroFormRenderer refactoring effort.

Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects for datetime fields which are then passed to an FtlWriter for evaluation.

Added tests to document how rendering parameters are generated for datetime fields.

Simplified generation of selectable minute options for date-time fields used in time-dropdown mode.

Moved typing of the date-time field's step, type, mask and clock attributes to DateTimeField model to ensure they are checked when the model is instantiated. The type and clock attributes are exposed by the model as boolean getters to check field types and whether a 12 or 24-hour clock should be used. These changes remove the need for client code to decode the various string attributes.

Removed redundant code which enabled/disabled encoding of date-time field output

> Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-12126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12126
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework/widget
>    Affects Versions: Trunk, Upcoming Branch
>            Reporter: Daniel Watford
>            Assignee: Daniel Watford
>            Priority: Minor
>
> As part of refactoring MacroFormRenderer (OFBIZ-11456), the renderDateTimeField method should be refactored to create RenderableFtlElements and pass them to an FtlWriter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)