[superset] 07/09: chore: remove redundant adodbapi warning (#19557)

[vi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 1.5
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 280ecab0e6a7a7828fe2425b67cc68ba6795f3d3
Author: Ville Brofeldt <33...@users.noreply.github.com>
AuthorDate: Thu Apr 7 14:30:36 2022 +0300

    chore: remove redundant adodbapi warning (#19557)
    
    (cherry picked from commit 0d331f5bd81f25bc92a20da6ed8d99f0c393efb2)
---
 superset/db_engine_specs/__init__.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/superset/db_engine_specs/__init__.py b/superset/db_engine_specs/__init__.py
index 9eeb87acfe..4474f2a748 100644
--- a/superset/db_engine_specs/__init__.py
+++ b/superset/db_engine_specs/__init__.py
@@ -116,6 +116,9 @@ def get_available_engine_specs() -> Dict[Type[BaseEngineSpec], Set[str]]:
                 hasattr(attribute, "dialect")
                 and inspect.isclass(attribute.dialect)
                 and issubclass(attribute.dialect, DefaultDialect)
+                # adodbapi dialect is removed in SQLA 1.4 and doesn't implement the
+                # `dbapi` method, hence needs to be ignored to avoid logging a warning
+                and attribute.dialect.driver != "adodbapi"
             ):
                 try:
                     attribute.dialect.dbapi()