[jira] [Commented] (FLINK-7500) Set JobMaster leader session id in main thread

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139955#comment-16139955 ] 

ASF GitHub Bot commented on FLINK-7500:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4579

    [FLINK-7500] Set JobMaster leader session id in main thread

    ## What is the purpose of the change
    
    This commit changes the JobMaster such that it's leader session id is only set
    in the main thread. This is done by passing the leader session id to the
    startJobExecution method. Moreover, this commit returns a future from the
    start and suspend methods which can be used to wait on the completion of these
    operations.
    
    This PR is based on #4573.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink jobMasterLeaderElection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4579
    
----
commit 97ba694bf5ffbbf8a0687aa6c22d9ab1d4a63489
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-22T14:33:05Z

    [FLINK-7489] Remove startJobExecution and suspendExecution from JobMasterGateway
    
    The job lifecycle methods should not be exposed as RPCs. Therefore, this commit
    removes them from the JobMasterGateway definition.

commit 1b6bdd87c8ec9e37c6322d89e91d95ffe02fb09c
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-24T11:24:15Z

    [FLINK-7500] Set JobMaster leader session id in main thread
    
    This commit changes the JobMaster such that it's leader session id is only set
    in the main thread. This is done by passing the leader session id to the
    startJobExecution method. Moreover, this commit returns a future from the
    start and suspend methods which can be used to wait on the completion of these
    operations.

----


> Set JobMaster leader session id in main thread
> ----------------------------------------------
>
>                 Key: FLINK-7500
>                 URL: https://issues.apache.org/jira/browse/FLINK-7500
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> Currently, the {{JobMaster}} leader id is set via an {{AtomicReferenceUpdater}}. In order to make it work with the new {{FencedRpcEndpoint}} it should be set in the main thread, because the former only allows to modify the leader session id from the main thread.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)