[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33917: [SPARK-36622][CORE] Making spark.history.kerberos.principal _HOST compliant

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #33917:
URL: https://github.com/apache/spark/pull/33917#discussion_r704928498



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
##########
@@ -32,6 +32,7 @@ import com.google.common.primitives.Longs
 import org.apache.hadoop.conf.Configuration
 import org.apache.hadoop.fs._
 import org.apache.hadoop.mapred.JobConf
+import org.apache.hadoop.security.{SecurityUtil}

Review comment:
       One import not use `{}`

##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -345,8 +345,9 @@ object HistoryServer extends Logging {
     // occur from the keytab.
     if (conf.get(History.KERBEROS_ENABLED)) {
       // if you have enabled kerberos the following 2 params must be set
-      val principalName = conf.get(History.KERBEROS_PRINCIPAL)
-        .getOrElse(throw new NoSuchElementException(History.KERBEROS_PRINCIPAL.key))
+      val principalName = SparkHadoopUtil.get.getServerPrincipal(conf

Review comment:
       How thrit server handle this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org