You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/08/17 19:48:11 UTC
[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/116
CB-9499: There is a run failure when trying to deploy an x64 app when…
… running on an x86 version of Node. This change addresses the problem by modifying the run process by detecting an x64 app package as the primary, and setting the environment architecture to x64 before invoking PowerShell.
Also, small build item to point to the correct location of WinJS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-9499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit af880a3629f6e69bae41c671b4fbd1b44b7714ee
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-08-17T17:47:11Z
CB-9499: There is a run failure when trying to deploy an x64 app when running on an x86 version of Node. This change addresses the problem by modifying the run process by detecting an x64 app package as the primary, and setting the environment architecture to x64 before invoking PowerShell.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/116#discussion_r37230334
--- Diff: template/cordova/lib/package.js ---
@@ -215,13 +215,20 @@ module.exports.deployToDesktop = function (package, deployTarget) {
return utils.getAppStoreUtils().then(function(appStoreUtils) {
return getPackageName(path.join(__dirname, '..', '..')).then(function(pkgname) {
+
+ var oldArch;
// uninstalls previous application instance (if exists)
console.log('Attempt to uninstall previous application version...');
return spawn('powershell', ['-ExecutionPolicy', 'RemoteSigned', 'Import-Module "' + appStoreUtils + '"; Uninstall-App ' + pkgname])
.then(function() {
console.log('Attempt to install application...');
+ oldArch = process.env.PROCESSOR_ARCHITECTURE;
+ if (package.arch === 'x64') {
+ process.env.PROCESSOR_ARCHITECTURE = 'AMD64';
+ }
return spawn('powershell', ['-ExecutionPolicy', 'RemoteSigned', 'Import-Module "' + appStoreUtils + '"; Install-App', utils.quote(package.script)]);
--- End diff --
If we throw here the PROCESSOR_ARCHITECTURE will remain changed. While this currently has no side effects, we probably want to have a catch promise and set the PROCESSOR_ARCHITECTURE to the original value since it's a shared value. LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/116#discussion_r37243479
--- Diff: template/cordova/lib/package.js ---
@@ -215,13 +215,20 @@ module.exports.deployToDesktop = function (package, deployTarget) {
return utils.getAppStoreUtils().then(function(appStoreUtils) {
return getPackageName(path.join(__dirname, '..', '..')).then(function(pkgname) {
+
+ var oldArch;
// uninstalls previous application instance (if exists)
console.log('Attempt to uninstall previous application version...');
return spawn('powershell', ['-ExecutionPolicy', 'RemoteSigned', 'Import-Module "' + appStoreUtils + '"; Uninstall-App ' + pkgname])
.then(function() {
console.log('Attempt to install application...');
+ oldArch = process.env.PROCESSOR_ARCHITECTURE;
+ if (package.arch === 'x64') {
+ process.env.PROCESSOR_ARCHITECTURE = 'AMD64';
+ }
return spawn('powershell', ['-ExecutionPolicy', 'RemoteSigned', 'Import-Module "' + appStoreUtils + '"; Install-App', utils.quote(package.script)]);
--- End diff --
Addressed by update. Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/116#issuecomment-131921926
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9499: There is a run failure when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org