[jira] Commented: (HARMONY-3015) [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs

["Sian January (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498560 ] 

Sian January commented on HARMONY-3015:
---------------------------------------

Hi Alexei,

Thanks for checking all that in - it all looks fine.

In reply to 2): I defined hashCode() for all those classes because one of the rules of programming in Java is that if you override the equals() method you should always override hashCode() because equal objects must always have equal hash codes.  I'm not sure why I use 37 - I think I was taught to do the hash like that at some point to get a good range of hash values for different Objects, but I can't remember why it's 37 rather than 36 or 38 or another number to be honest!

1) and 3) - great!

> [classlib] [security] Fixes for some minor bugs in the security module found by FindBugs
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3015
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3015
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>         Attachments: exclusionFilter.xml.patch, exclusionFilter.xml.patch2, security.patch, security.patch2
>
>
> I am attaching a patch containing fixes for minor issues in the security module, and also a second patch for the exclusionFilter.xml file found in standard/tools/FindBugs to exclude false positives in the same module.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.