[GitHub] [spark] maryannxue commented on pull request #36845: [SPARK-39447][SQL] Only non-broadcast query stage can propagate empty relation

[GitBox <gi...@apache.org>]

maryannxue commented on PR #36845:
URL: https://github.com/apache/spark/pull/36845#issuecomment-1154125105

   @wangyum I don't think this fix will solve all problems. Empty relation propagation can cause invalid plans in other ways, e.g., a `BroadcastExchangeExec` ending up as the child of a random plan node other than BHJ or BNLJ. So you can approach this problem from a different angle. Have an invalid plan checker to detect those patterns and throw a specific exception that can be caught by `AdaptiveSparkPlanExec`'s replanning method and so it can void the latest plan and keep the old valid plan in use.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org