You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/09/11 19:55:48 UTC
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14215
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
IMPALA-8935: Add links to other daemons from webui
This patch adds links on the /backends page of the webui to the
webuis for the other backends.
Testing:
- Updated test_backends_page to check for the webui links.
Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
---
M be/src/service/impala-http-handler.cc
M tests/webserver/test_web_pages.py
M www/backends.tmpl
3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/14215/1
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14215 )
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
IMPALA-8935: Add links to other daemons from webui
This patch adds links on the /backends page of the webui to the
webuis for the other backends.
Testing:
- Updated test_backends_page to check for the webui links.
Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Reviewed-on: http://gerrit.cloudera.org:8080/14215
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-http-handler.cc
M tests/webserver/test_web_pages.py
M www/backends.tmpl
3 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14215 )
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Sep 2019 01:38:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14215 )
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4543/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Sep 2019 20:36:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14215 )
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2019 21:28:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14215 )
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4946/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2019 21:28:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8935: Add links to other daemons from webui
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14215 )
Change subject: IMPALA-8935: Add links to other daemons from webui
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f92ed47ea3d96dbb8837f23467906510aec2e78
Gerrit-Change-Number: 14215
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2019 21:26:25 +0000
Gerrit-HasComments: No