You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/07/14 09:21:00 UTC

[jira] [Commented] (IMPALA-12056) Child queries could get scheduled on improper executor group sets

    [ https://issues.apache.org/jira/browse/IMPALA-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743065#comment-17743065 ] 

ASF subversion and git services commented on IMPALA-12056:
----------------------------------------------------------

Commit c9aed342f54494d2f0b5e5aada472d6af6697adc in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c9aed342f ]

IMPALA-12281: Disallow unsetting REQUEST_POOL if it is set by client

IMPALA-12056 enable child query to unset REQUEST_POOL if it is set by
Frontend.java as part of executor group selection. However, the
implementation miss to setRequest_pool_set_by_frontend(false) if
REQUEST_POOL is explicitly set by client request through impala-shell
configuration. This cause child query to always unset REQUEST_POOL if
parent query was executed via impala-shell. This patch fix the issue by
checking query options that comes from client.

This patch also tidy up null and empty REQUEST_POOL checking by using
StringUtils.isNotEmpty().

Testing:
- Add testcase in test_query_cpu_count_divisor_default

Change-Id: Ib5036859d51bc64f568da405f730c8f3ffebb742
Reviewed-on: http://gerrit.cloudera.org:8080/20189
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Riza Suminto <ri...@cloudera.com>


> Child queries could get scheduled on improper executor group sets
> -----------------------------------------------------------------
>
>                 Key: IMPALA-12056
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12056
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Abhishek Rawat
>            Assignee: Riza Suminto
>            Priority: Critical
>             Fix For: Impala 4.3.0
>
>
> 'Compute Stats' queries gets scheduled on the smallest executor group set since these queries don't do any real work. However their child queries also gets scheduled on the smallest executor group. This may not be ideal for cases where the child query does NDVs and Counts on a big wide table. We should assign the executor group set for the children queries based on their planning estimates.
> Today we see following message for the parent query, which. makes sense:
> {code:java}
> Verdict: Assign to first group because query is not auto-scalable {code}
> as a side effect we see following message for child queries:
> {code:java}
> Verdict: query option REQUEST_POOL=root.group-set-small is set. Memory and cpu limit checking is skipped. {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org