[GitHub] merlimat commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls
URL: https://github.com/apache/incubator-pulsar/pull/1147#discussion_r164941254
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/AuthenticationFactory.java
 ##########
 @@ -81,8 +65,9 @@ public static final Authentication create(String authPluginClassName, String aut
      * @param authParams          map which represents parameters for the Authentication-Plugin
      * @return instance of the Authentication-Plugin
      * @throws UnsupportedAuthenticationException
+     * @deprecated Use create(String authPluginClassName, String authParamsString)
      */
-    @SuppressWarnings("deprecation")
+    @Deprecated
     public static final Authentication create(String authPluginClassName, Map<String, String> authParams)
 
 Review comment:
   @maskit While I agree we don't need 2 ways to configure the authentication for plugins, could we leave it for users? We can still encode the map internally and pass it to the plugin. 
   
   In some cases, if you're not getting the auth settings from a file, but rather set in code, for a user it's easier to fill up a map than then figure out the specific encoding

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services