You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/01/05 10:50:12 UTC
[jira] [Commented] (BOOKKEEPER-532)
AbstractSubscriptionManager#AcquireOp read subscriptions every time even it
already owned the topic
[ https://issues.apache.org/jira/browse/BOOKKEEPER-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544645#comment-13544645 ]
Hadoop QA commented on BOOKKEEPER-532:
--------------------------------------
Testing JIRA BOOKKEEPER-532
Patch [BOOKKEEPER-532.diff|https://issues.apache.org/jira/secure/attachment/12563408/BOOKKEEPER-532.diff] downloaded at Sat Jan 5 08:49:41 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/204/
> AbstractSubscriptionManager#AcquireOp read subscriptions every time even it already owned the topic
> ---------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-532
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-532
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-532.diff
>
>
> {code}
> private class AcquireOp extends TopicOpQueuer.AsynchronousOp<Void> {
> public AcquireOp(ByteString topic, Callback<Void> callback, Object ctx) {
> queuer.super(topic, callback, ctx);
> }
> @Override
> public void run() {
> if (top2sub2seq.containsKey(topic)) {
> cb.operationFinished(ctx, null);
> }
> readSubscriptions(topic, new Callback<Map<ByteString, InMemorySubscriptionState>>() {
> {code}
> it doesn't return after it found subscriptions and callback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira