[DISCUSSION] - Support Groups in RepoInit

[Daniel Klco <dk...@apache.org>]

Currently, the RepoInit grammer does not seem to support creating groups,
which is somewhat problematic if you want to be able to assign both service
user and group ACLs during the RepoInit process.

As mentioned in SLING-5499[1], this was planned and adding support for
groups should be discussed.

I've created pull requests to add the necessary changes to the RepoInit
Parser[2] and JCR RepoInit[3]. They include the necessary changes to the
parser and JCR implementation to support creating and deleting groups as
well as associated tests.

Does anyone have any concerns with this or other feedback?

1 -
https://issues.apache.org/jira/browse/SLING-5449?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=15339416#comment-15339416
2 - https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/2
3 - https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/4

Re: [DISCUSSION] - Support Groups in RepoInit

[Daniel Klco <dk...@apache.org>]

Thanks for catching that! Fixed and merged!

On Wed, Jan 16, 2019 at 10:39 AM Bertrand Delacretaz <bd...@apache.org>
wrote:

> Hi,
>
> On Wed, Jan 16, 2019 at 6:28 AM Daniel Klco <dk...@apache.org> wrote:
> > ...I've created pull requests to add the necessary changes to the
> RepoInit
> > Parser[2] and JCR RepoInit[3]...
>
> Thank you for this!
>
> It all looks good to me, your patches are consistent with the current
> style of the language and code which is great.
>
> One very minor thing, in CreateGroupsTest the createUserWithPathTest
> method should be named createGroup...
>
> IMO you can go ahead, create a jira ticket and commit this.
>
> -Bertrand
>
> > 2 -
> https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/2
> > 3 - https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/4
>

Re: [DISCUSSION] - Support Groups in RepoInit

[Bertrand Delacretaz <bd...@apache.org>]

Hi,

On Wed, Jan 16, 2019 at 6:28 AM Daniel Klco <dk...@apache.org> wrote:
> ...I've created pull requests to add the necessary changes to the RepoInit
> Parser[2] and JCR RepoInit[3]...

Thank you for this!

It all looks good to me, your patches are consistent with the current
style of the language and code which is great.

One very minor thing, in CreateGroupsTest the createUserWithPathTest
method should be named createGroup...

IMO you can go ahead, create a jira ticket and commit this.

-Bertrand

> 2 - https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/2
> 3 - https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/4