You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by js...@apache.org on 2009/10/03 23:50:41 UTC

svn commit: r821426 - in /tuscany/cpp/sca: kernel/ modules/eval/ test/store-function/

Author: jsdelfino
Date: Sat Oct  3 21:50:40 2009
New Revision: 821426

URL: http://svn.apache.org/viewvc?rev=821426&view=rev
Log:
Removed explicit C++ keywords to let the compiler perform the necessary conversions.

Modified:
    tuscany/cpp/sca/kernel/function.hpp
    tuscany/cpp/sca/kernel/gc.hpp
    tuscany/cpp/sca/kernel/kernel-test.cpp
    tuscany/cpp/sca/kernel/list.hpp
    tuscany/cpp/sca/kernel/parallel.hpp
    tuscany/cpp/sca/kernel/value.hpp
    tuscany/cpp/sca/kernel/xml.hpp
    tuscany/cpp/sca/modules/eval/driver.hpp
    tuscany/cpp/sca/modules/eval/environment.hpp
    tuscany/cpp/sca/modules/eval/eval-test
    tuscany/cpp/sca/modules/eval/eval-test.cpp
    tuscany/cpp/sca/modules/eval/eval.hpp
    tuscany/cpp/sca/modules/eval/primitive.hpp
    tuscany/cpp/sca/modules/eval/read.hpp
    tuscany/cpp/sca/test/store-function/cart.hpp
    tuscany/cpp/sca/test/store-function/catalog.hpp
    tuscany/cpp/sca/test/store-function/currency.hpp
    tuscany/cpp/sca/test/store-function/item.hpp
    tuscany/cpp/sca/test/store-function/store-function-test.cpp
    tuscany/cpp/sca/test/store-function/store-ui.hpp

Modified: tuscany/cpp/sca/kernel/function.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/function.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/function.hpp (original)
+++ tuscany/cpp/sca/kernel/function.hpp Sat Oct  3 21:50:40 2009
@@ -86,12 +86,12 @@
 
     template<typename F> class Proxy: public Callable {
     public:
-        explicit Proxy(const F& f) : function(f) {
+        Proxy(const F& f) : function(f) {
             countProxies++;
             countFProxies ++;
         }
 
-        explicit Proxy(const Proxy& p) : function(p.function) {
+        Proxy(const Proxy& p) : function(p.function) {
             countProxies++;
             countCProxies ++;
         }
@@ -123,7 +123,7 @@
         countELambdas++;
     }
 
-    template<typename F> explicit lambda(const F f) : callable(0) {
+    template<typename F> lambda(const F f) : callable(0) {
         typedef typename CallableType::template Proxy<F> ProxyType;
 
         countLambdas++;
@@ -214,7 +214,7 @@
  */
 template<typename T> class unitReturn {
 public:
-    explicit unitReturn(const T& v) :
+    unitReturn(const T& v) :
         v(v) {
     }
     const T operator()() const {

Modified: tuscany/cpp/sca/kernel/gc.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/gc.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/gc.hpp (original)
+++ tuscany/cpp/sca/kernel/gc.hpp Sat Oct  3 21:50:40 2009
@@ -33,7 +33,7 @@
 
 template<typename T> class gc_ptr {
 public:
-    explicit gc_ptr(T* p = 0) throw() : countingRef(p == 0? 0 : new CountingRef(p)) {
+    gc_ptr(T* p = 0) throw() : countingRef(p == 0? 0 : new CountingRef(p)) {
     }
 
     ~gc_ptr() throw() {
@@ -116,7 +116,7 @@
  */
 template<typename T> class gc_aptr {
 public:
-    explicit gc_aptr(T* p = 0) throw() : countingRef(p == 0? 0 : new CountingRef(p)) {
+    gc_aptr(T* p = 0) throw() : countingRef(p == 0? 0 : new CountingRef(p)) {
     }
 
     ~gc_aptr() throw() {
@@ -199,7 +199,7 @@
  */
 template<typename T> class gc_counting_ptr {
 public:
-    explicit gc_counting_ptr(T* p = 0) throw() : ptr(p) {
+    gc_counting_ptr(T* p = 0) throw() : ptr(p) {
         acquire(p);
     }
 

Modified: tuscany/cpp/sca/kernel/kernel-test.cpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/kernel-test.cpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/kernel-test.cpp (original)
+++ tuscany/cpp/sca/kernel/kernel-test.cpp Sat Oct  3 21:50:40 2009
@@ -248,7 +248,7 @@
 }
 
 value valueSquare(list<value> x) {
-    return value((int)car(x) * (int)car(x));
+    return (int)car(x) * (int)car(x);
 }
 
 bool testValue() {
@@ -257,7 +257,7 @@
     assert(value("abcd") == value("abcd"));
     lambda<value(list<value>&)> vl(valueSquare);
     assert(value(vl) == value(vl));
-    assert(value(makeList(value(1), value(2))) == value(makeList(value(1), value(2))));
+    assert(value(makeList<value>(1, 2)) == value(makeList<value>(1, 2)));
     return true;
 }
 
@@ -390,7 +390,7 @@
 
 bool testReadXML() {
     std::istringstream is(currencyXML);
-    const list<value> currency = value(readXML(is));
+    const list<value> currency = readXML(is);
 
     const value composite = car(currency);
     assert(isElement(composite));
@@ -403,7 +403,7 @@
 
 bool testWriteXML() {
     std::istringstream is(currencyXML);
-    const list<value> currency = value(readXML(is));
+    const list<value> currency = readXML(is);
     std::ostringstream os;
     writeXML(currency, os);
     assert(os.str() == currencyXML);

Modified: tuscany/cpp/sca/kernel/list.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/list.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/list.hpp (original)
+++ tuscany/cpp/sca/kernel/list.hpp Sat Oct  3 21:50:40 2009
@@ -269,7 +269,7 @@
  */
 template<typename T, typename R> struct reduceAccumulate {
     const lambda<R(R, T)> f;
-    explicit reduceAccumulate(const lambda<R(R, T)>& f) :
+    reduceAccumulate(const lambda<R(R, T)>& f) :
         f(f) {
     }
     R operator()(const R& acc, const list<T>& p) const {

Modified: tuscany/cpp/sca/kernel/parallel.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/parallel.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/parallel.hpp (original)
+++ tuscany/cpp/sca/kernel/parallel.hpp Sat Oct  3 21:50:40 2009
@@ -139,7 +139,7 @@
  */
 template<typename T> class queue {
 public:
-    explicit queue(int max) : max(max), size(0), tail(0), head(0), values(new T[max]) {
+    queue(int max) : max(max), size(0), tail(0), head(0), values(new T[max]) {
         pthread_mutex_init(&mutex, NULL);
         pthread_cond_init(&full, NULL);
         pthread_cond_init(&empty, NULL);
@@ -221,7 +221,7 @@
  */
 class worker {
 public:
-    explicit worker(int max) : work(queue<lambda<bool()> >(max)), threads(makeWorkerThreads(work, max)) {
+    worker(int max) : work(queue<lambda<bool()> >(max)), threads(makeWorkerThreads(work, max)) {
     }
 
 private:

Modified: tuscany/cpp/sca/kernel/value.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/value.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/value.hpp (original)
+++ tuscany/cpp/sca/kernel/value.hpp Sat Oct  3 21:50:40 2009
@@ -121,49 +121,49 @@
         countValues--;
     }
 
-    explicit value(const lambda<value(list<value>&)>& func) :
+    value(const lambda<value(list<value>&)>& func) :
         type(value::Lambda), data(vdata(func)) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const std::string& str) :
+    value(const std::string& str) :
         type(value::String), data(vdata(unit(str))) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const char* str) :
+    value(const char* str) :
         type(value::Symbol), data(vdata(unit(std::string(str)))) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const list<value>& lst) :
+    value(const list<value>& lst) :
         type(value::List), data(vdata(unit(lst))) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const double num) :
+    value(const double num) :
         type(value::Number), data(vdata(unit(num))) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const int num) :
+    value(const int num) :
         type(value::Number), data(vdata(unit((double)num))) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const bool boo) :
+    value(const bool boo) :
         type(value::Boolean), data(vdata(unit(boo))) {
         countValues++;
         countVValues++;
     }
 
-    explicit value(const char chr) :
+    value(const char chr) :
         type(value::Character), data(vdata(unit(chr))) {
         countValues++;
         countVValues++;

Modified: tuscany/cpp/sca/kernel/xml.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/kernel/xml.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/kernel/xml.hpp (original)
+++ tuscany/cpp/sca/kernel/xml.hpp Sat Oct  3 21:50:40 2009
@@ -46,7 +46,7 @@
         None = 0, Element = 1, Attribute = 2, EndElement = 15, Identifier = 100, Text = 101, End = 103
     };
 
-    explicit XmlReader(xmlTextReaderPtr xml) : xml(xml), tokenType(None) {
+    XmlReader(xmlTextReaderPtr xml) : xml(xml), tokenType(None) {
         xmlTextReaderSetParserProp(xml, XML_PARSER_DEFAULTATTRS, 1);
         xmlTextReaderSetParserProp(xml, XML_PARSER_SUBST_ENTITIES, 1);
     }

Modified: tuscany/cpp/sca/modules/eval/driver.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/driver.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/modules/eval/driver.hpp (original)
+++ tuscany/cpp/sca/modules/eval/driver.hpp Sat Oct  3 21:50:40 2009
@@ -48,8 +48,7 @@
 
 const bool userPrint(std::ostream& out, const value object) {
     if(isCompoundProcedure(object))
-        out << makeList(compoundProcedureSymbol, value(procedureParameters(object)), value(procedureBody(object)), value(
-                "<procedure-env>"));
+        out << makeList<value>(compoundProcedureSymbol, procedureParameters(object), procedureBody(object), "<procedure-env>");
     out << object;
     return true;
 }

Modified: tuscany/cpp/sca/modules/eval/environment.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/environment.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/modules/eval/environment.hpp (original)
+++ tuscany/cpp/sca/modules/eval/environment.hpp Sat Oct  3 21:50:40 2009
@@ -37,11 +37,11 @@
 typedef value Frame;
 typedef list<value> Env;
 
-const value trueSymbol = value("true");
-const value falseSymbol = value("false");
-const value defineSymbol = value("define");
-const value setSymbol = value("set!");
-const value dotSymbol = value(".");
+const value trueSymbol("true");
+const value falseSymbol("false");
+const value defineSymbol("define");
+const value setSymbol("set!");
+const value dotSymbol(".");
 
 const Env theEmptyEnvironment() {
     return list<value>();
@@ -86,7 +86,7 @@
         return frameSoFar;
     }
     if (isDotVariable(car(variables)))
-        return makeBinding(frameSoFar, cdr(variables), makeList(value(values)));
+        return makeBinding(frameSoFar, cdr(variables), makeList<value>(values));
 
     if (values == list<value>()) {
         if (variables != list<value>())
@@ -96,13 +96,13 @@
 
     const list<value> vars = cons(car(variables), frameVariables(frameSoFar));
     const list<value> vals = cons(car(values), frameValues(frameSoFar));
-    const Frame newFrame = value(cons(value(vars), vals));
+    const Frame newFrame = cons(value(vars), vals);
 
     return makeBinding(newFrame, cdr(variables), cdr(values));
 }
 
 const Frame makeFrame(const list<value>& variables, const list<value> values) {
-    const Frame emptyFrame = value(cons((value)list<value>(), list<value>()));
+    const Frame emptyFrame = cons(value(list<value>()), list<value>());
     return makeBinding(emptyFrame, variables, values);
 }
 
@@ -131,11 +131,11 @@
 }
 
 const Frame addBindingToFrame(const value& var, const value& val, const Frame& frame) {
-    return value(cons((value)cons(var, frameVariables(frame)), cons(val, frameValues(frame))));
+    return cons(value(cons(var, frameVariables(frame))), cons(val, frameValues(frame)));
 }
 
 const Env defineVariable(const value& var, const value& val, Env& env) {
-    return value(cons(addBindingToFrame(var, val, firstFrame(env)), cdr(env)));
+    return cons(addBindingToFrame(var, val, firstFrame(env)), cdr(env));
 }
 
 const Env extendEnvironment(const list<value>& vars, const list<value>& vals, const Env& baseEnv) {
@@ -150,8 +150,8 @@
 
 const Env setupEnvironment() {
     Env env = extendEnvironment(primitiveProcedureNames(), primitiveProcedureObjects(), theEmptyEnvironment());
-    env = defineVariable(trueSymbol, value(true), env);
-    env = defineVariable(falseSymbol, value(false), env);
+    env = defineVariable(trueSymbol, true, env);
+    env = defineVariable(falseSymbol, false, env);
     return env;
 }
 

Modified: tuscany/cpp/sca/modules/eval/eval-test
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/eval-test?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
Files tuscany/cpp/sca/modules/eval/eval-test (original) and tuscany/cpp/sca/modules/eval/eval-test Sat Oct  3 21:50:40 2009 differ

Modified: tuscany/cpp/sca/modules/eval/eval-test.cpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/eval-test.cpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/modules/eval/eval-test.cpp (original)
+++ tuscany/cpp/sca/modules/eval/eval-test.cpp Sat Oct  3 21:50:40 2009
@@ -33,10 +33,10 @@
 
 bool testEnv() {
     Env globalEnv = list<value>();
-    Env env = extendEnvironment(makeList(value("a")), makeList(value(1)), globalEnv);
-    defineVariable(value("x"), value(env), env);
+    Env env = extendEnvironment(makeList<value>("a"), makeList<value>(1), globalEnv);
+    defineVariable("x", env, env);
     //assert(lookupVariableValue(value("x"), env) == env);
-    assert(lookupVariableValue(value("a"), env) == value(1));
+    assert(lookupVariableValue("a", env) == value(1));
     return true;
 }
 
@@ -56,19 +56,19 @@
 
 bool testRead() {
     std::istringstream is("abcd");
-    assert(read(is) == value("abcd"));
+    assert(read(is) == "abcd");
 
     std::istringstream is2("123");
     assert(read(is2) == value(123));
 
     std::istringstream is3("(abcd)");
-    assert(read(is3) == value(makeList(value("abcd"))));
+    assert(read(is3) == makeList(value("abcd")));
 
     std::istringstream is4("(abcd xyz)");
-    assert(read(is4) == value(makeList(value("abcd"), value("xyz"))));
+    assert(read(is4) == makeList<value>("abcd", "xyz"));
 
     std::istringstream is5("(abcd (xyz tuv))");
-    assert(read(is5) == value(makeList(value("abcd"), value(makeList(value("xyz"), value("tuv"))))));
+    assert(read(is5) == makeList<value>("abcd", makeList<value>("xyz", "tuv")));
 
     return true;
 }
@@ -133,10 +133,10 @@
 }
 
 bool testEvalExpr() {
-    const value exp = value(makeList(value("+"), value(2), value(3)));
+    const value exp = makeList<value>("+", 2, 3);
     Env env = setupEnvironment();
     const value r = eval(exp, env);
-    assert(value(5) == r);
+    assert(r == value(5));
     return true;
 }
 

Modified: tuscany/cpp/sca/modules/eval/eval.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/eval.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/modules/eval/eval.hpp (original)
+++ tuscany/cpp/sca/modules/eval/eval.hpp Sat Oct  3 21:50:40 2009
@@ -67,7 +67,7 @@
 }
 
 const value makeProcedure(const list<value>& parameters, const value& body, const Env& env) {
-    return value(makeList(procedureSymbol, value(parameters), body, value(env)));
+    return makeList<value>(procedureSymbol, parameters, body, env);
 }
 
 const bool isApply(const value& exp) {
@@ -129,7 +129,7 @@
 }
 
 const value makeBegin(const list<value> seq) {
-    return value(cons(beginSymbol, seq));
+    return cons(beginSymbol, seq);
 }
 
 const value evalSequence(const list<value>& exps, Env& env) {
@@ -152,7 +152,7 @@
 
 const value sequenceToExp(const list<value> exps) {
     if(exps == list<value> ())
-        return value(list<value>());
+        return list<value>();
     if(isLastExp(exps))
         return firstExp(exps);
     return makeBegin(exps);
@@ -181,7 +181,7 @@
 const value ifAlternative(const value& exp) {
     if(cdr(cdr(cdr((list<value> )exp))) != list<value> ())
         return car(cdr(cdr(cdr((list<value> )exp))));
-    return value(false);
+    return false;
 }
 
 const bool isCond(const value& exp) {
@@ -197,12 +197,12 @@
 }
 
 const value makeIf(value predicate, value consequent, value alternative) {
-    return value(makeList(ifSymbol, predicate, consequent, alternative));
+    return makeList(ifSymbol, predicate, consequent, alternative);
 }
 
 const value expandClauses(const list<value>& clauses) {
     if(clauses == list<value> ())
-        return value(false);
+        return false;
     const value first = car(clauses);
     const list<value> rest = cdr(clauses);
     if(isCondElseClause(first)) {
@@ -243,7 +243,7 @@
     if(isCond(exp))
         return eval(condToIf(exp), env);
     if(isLambda(exp))
-        return makeProcedure(lambdaParameters(exp), value(lambdaBody(exp)), env);
+        return makeProcedure(lambdaParameters(exp), lambdaBody(exp), env);
     if(isVariable(exp))
         return lookupVariableValue(exp, env);
     if(isApply(exp)) {

Modified: tuscany/cpp/sca/modules/eval/primitive.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/primitive.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/modules/eval/primitive.hpp (original)
+++ tuscany/cpp/sca/modules/eval/primitive.hpp Sat Oct  3 21:50:40 2009
@@ -50,53 +50,53 @@
 }
 
 const value valueCdr(list<value>& args) {
-    return value(cdr((list<value> )car(args)));
+    return cdr((list<value> )car(args));
 }
 
 const value valueCons(list<value>& args) {
-    return value(cons(car(args), (list<value> )cadr(args)));
+    return cons(car(args), (list<value> )cadr(args));
 }
 
 const value valueList(list<value>& args) {
-    return value(args);
+    return args;
 }
 
 const value valueNul(list<value>& args) {
-    return value((bool)isNil(car(args)));
+    return (bool)isNil(car(args));
 }
 
 const value valueEqual(list<value>& args) {
-    return value((bool)(car(args) == cadr(args)));
+    return (bool)(car(args) == cadr(args));
 }
 
 const value valueAdd(list<value>& args) {
     if (cdr(args) == list<value>())
-        return value((double)car(args));
-    return value((double)car(args) + (double)cadr(args));
+        return (double)car(args);
+    return (double)car(args) + (double)cadr(args);
 }
 
 const value valueSub(list<value>& args) {
     if (cdr(args) == list<value>())
-        return value(0 - (double)car(args));
-    return value((double)car(args) - (double)cadr(args));
+        return (double)0 - (double)car(args);
+    return (double)car(args) - (double)cadr(args);
 }
 
 const value valueMul(list<value>& args) {
-    return value((double)car(args) * (double)cadr(args));
+    return (double)car(args) * (double)cadr(args);
 }
 
 const value valueDiv(list<value>& args) {
-    return value((double)car(args) / (double)cadr(args));
+    return (double)car(args) / (double)cadr(args);
 }
 
 const value valueDisplay(list<value>& args) {
     *evalOut << car(args);
-    return value(true);
+    return true;
 }
 
 const value valueError(list<value>& args) {
     std::cerr << (std::string)car(args);
-    return value(true);
+    return true;
 }
 
 const value applyPrimitiveProcedure(const value& proc, list<value>& args) {
@@ -127,22 +127,22 @@
 }
 
 template<typename F> const value primitiveProcedure(const F& f) {
-    return value(makeList(primitiveSymbol, value((lambda<value(list<value>&)>)f)));
+    return makeList<value>(primitiveSymbol, (lambda<value(list<value>&)>)f);
 }
 
 const list<value> primitiveProcedureNames() {
-    list<value> l = makeList(value("car"));
-    l = cons(value("cdr"), l);
-    l = cons(value("cons"), l);
-    l = cons(value("list"), l);
-    l = cons(value("nul"), l);
-    l = cons(value("="), l);
-    l = cons(value("+"), l);
-    l = cons(value("-"), l);
-    l = cons(value("*"), l);
-    l = cons(value("/"), l);
-    l = cons(value("equal?"), l);
-    l = cons(value("display"), l);
+    list<value> l = makeList<value>("car");
+    l = cons<value>("cdr", l);
+    l = cons<value>("cons", l);
+    l = cons<value>("list", l);
+    l = cons<value>("nul", l);
+    l = cons<value>("=", l);
+    l = cons<value>("+", l);
+    l = cons<value>("-", l);
+    l = cons<value>("*", l);
+    l = cons<value>("/", l);
+    l = cons<value>("equal?", l);
+    l = cons<value>("display", l);
     return l;
 }
 
@@ -179,7 +179,7 @@
 }
 
 const value makeLambda(const list<value>& parameters, const list<value>& body) {
-    return value(cons(lambdaSymbol, cons((value)parameters, body)));
+    return cons(lambdaSymbol, cons<value>(parameters, body));
 }
 
 }

Modified: tuscany/cpp/sca/modules/eval/read.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/modules/eval/read.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/modules/eval/read.hpp (original)
+++ tuscany/cpp/sca/modules/eval/read.hpp Sat Oct  3 21:50:40 2009
@@ -38,8 +38,8 @@
 namespace tuscany
 {
 
-const value rightParenthesis(makeList(value(")")));
-const value leftParenthesis(makeList(value("(")));
+const value rightParenthesis(makeList<value>(")"));
+const value leftParenthesis(makeList<value>("("));
 
 const double stringToNumber(const std::string& str) {
     double d;
@@ -120,7 +120,7 @@
 }
 
 const value readQuoted(std::istream& in) {
-    return value(makeList(quoteSymbol, read(in)));
+    return makeList(quoteSymbol, read(in));
 }
 
 const list<value> readList(const list<value>& listSoFar, std::istream& in) {
@@ -146,7 +146,7 @@
 }
 
 const value readIdentifier(const char chr, std::istream& in) {
-    return value(listToString(readIdentifierHelper(makeList(chr), in)).c_str());
+    return listToString(readIdentifierHelper(makeList(chr), in)).c_str();
 }
 
 const list<char> readStringHelper(const list<char>& listSoFar, std::istream& in) {
@@ -157,7 +157,7 @@
 }
 
 const value readString(const char chr, std::istream& in) {
-    return value(listToString(readStringHelper(list<char>(), in)));
+    return listToString(readStringHelper(list<char>(), in));
 }
 
 const list<char> readNumberHelper(const list<char>& listSoFar, std::istream& in) {
@@ -168,13 +168,13 @@
 }
 
 const value readNumber(const char chr, std::istream& in) {
-    return value(stringToNumber(listToString(readNumberHelper(makeList(chr), in))));
+    return stringToNumber(listToString(readNumberHelper(makeList(chr), in)));
 }
 
 const value read(std::istream& in) {
     const value nextToken = readToken(in);
     if(isLeftParenthesis(nextToken))
-        return value(readList(list<value> (), in));
+        return readList(list<value> (), in);
     return nextToken;
 }
 

Modified: tuscany/cpp/sca/test/store-function/cart.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/test/store-function/cart.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/test/store-function/cart.hpp (original)
+++ tuscany/cpp/sca/test/store-function/cart.hpp Sat Oct  3 21:50:40 2009
@@ -55,14 +55,14 @@
 }
 
 const tuscany::value shoppingCart_service(const tuscany::list<tuscany::value>& args) {
-    if (car(args) == tuscany::value("getAll"))
-        return tuscany::value(shoppingCart_getAll());
-    if (car(args) == tuscany::value("post"))
-        return tuscany::value(shoppingCart_post(cadr(args)));
-    if (car(args) == tuscany::value("deleteAll"))
-        return tuscany::value(shoppingCart_deleteAll());
-    if (car(args) == tuscany::value("getTotal"))
-        return tuscany::value(shoppingCart_getTotal());
+    if (car(args) == "getAll")
+        return shoppingCart_getAll();
+    if (car(args) == "post")
+        return shoppingCart_post(cadr(args));
+    if (car(args) == "deleteAll")
+        return shoppingCart_deleteAll();
+    if (car(args) == "getTotal")
+        return shoppingCart_getTotal();
     return tuscany::value();
 }
 

Modified: tuscany/cpp/sca/test/store-function/catalog.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/test/store-function/catalog.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/test/store-function/catalog.hpp (original)
+++ tuscany/cpp/sca/test/store-function/catalog.hpp Sat Oct  3 21:50:40 2009
@@ -33,20 +33,20 @@
 std::string catalog_currencyCode = "USD";
 
 double catalog_convert(const service& currencyConverter, const double price) {
-    return currencyConverter(makeList(tuscany::value("convert"), tuscany::value("USD"), tuscany::value(catalog_currencyCode), tuscany::value(price)));
+    return currencyConverter(tuscany::makeList<tuscany::value>("convert", "USD", catalog_currencyCode, price));
 }
 
 const tuscany::list<ItemType> catalog_get(const service& currencyConverter) {
-    const std::string currencySymbol = currencyConverter_service(makeList(tuscany::value("getSymbol"), tuscany::value(catalog_currencyCode)));
-    return makeList(
+    const std::string currencySymbol = currencyConverter_service(tuscany::makeList<tuscany::value>("getSymbol", catalog_currencyCode));
+    return tuscany::makeList(
             makeItem("Apple", catalog_currencyCode, currencySymbol, catalog_convert(currencyConverter, 2.99)),
             makeItem("Orange", catalog_currencyCode, currencySymbol, catalog_convert(currencyConverter, 3.55)),
             makeItem("Pear", catalog_currencyCode, currencySymbol, catalog_convert(currencyConverter, 1.55)));
 }
 
 const tuscany::value catalog_service(const service& currencyConverter, const tuscany::list<tuscany::value>& args) {
-    if (car(args) == tuscany::value("get"))
-        return tuscany::value(catalog_get(currencyConverter));
+    if (car(args) == "get")
+        return catalog_get(currencyConverter);
     return tuscany::value();
 }
 

Modified: tuscany/cpp/sca/test/store-function/currency.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/test/store-function/currency.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/test/store-function/currency.hpp (original)
+++ tuscany/cpp/sca/test/store-function/currency.hpp Sat Oct  3 21:50:40 2009
@@ -47,10 +47,10 @@
 }
 
 const tuscany::value currencyConverter_service(const tuscany::list<tuscany::value>& args) {
-    if (car(args) == tuscany::value("convert"))
-        return tuscany::value(currencyConverter_convert(cadr(args), car(cdr(cdr(args))), car(cdr(cdr(cdr(args))))));
-    if (car(args) == tuscany::value("getSymbol"))
-        return tuscany::value(currencyConverter_getSymbol(cadr(args)));
+    if (car(args) == "convert")
+        return currencyConverter_convert(cadr(args), car(cdr(cdr(args))), car(cdr(cdr(cdr(args)))));
+    if (car(args) == "getSymbol")
+        return currencyConverter_getSymbol(cadr(args));
     return tuscany::value();
 }
 

Modified: tuscany/cpp/sca/test/store-function/item.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/test/store-function/item.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/test/store-function/item.hpp (original)
+++ tuscany/cpp/sca/test/store-function/item.hpp Sat Oct  3 21:50:40 2009
@@ -31,7 +31,7 @@
 typedef tuscany::value ItemType;
 
 const ItemType makeItem(const std::string& name, const std::string& currencyCode, const std::string& currencySymbol, const double price) {
-    return tuscany::value(makeList(tuscany::value(name), tuscany::value(currencyCode), tuscany::value(currencySymbol), tuscany::value(price)));
+    return tuscany::makeList<tuscany::value>(name, currencyCode, currencySymbol, price);
 }
 
 const std::string itemName(const ItemType& item) {

Modified: tuscany/cpp/sca/test/store-function/store-function-test.cpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/test/store-function/store-function-test.cpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/test/store-function/store-function-test.cpp (original)
+++ tuscany/cpp/sca/test/store-function/store-function-test.cpp Sat Oct  3 21:50:40 2009
@@ -33,7 +33,7 @@
 
 bool testComponentAssembly() {
     const service store(storeSolution_service);
-    assert(length((tuscany::list<tuscany::value>)store(makeList(tuscany::value("getCatalog")))) == 3);
+    assert(length((tuscany::list<tuscany::value>)store(tuscany::makeList<tuscany::value>("getCatalog"))) == 3);
     return true;
 }
 

Modified: tuscany/cpp/sca/test/store-function/store-ui.hpp
URL: http://svn.apache.org/viewvc/tuscany/cpp/sca/test/store-function/store-ui.hpp?rev=821426&r1=821425&r2=821426&view=diff
==============================================================================
--- tuscany/cpp/sca/test/store-function/store-ui.hpp (original)
+++ tuscany/cpp/sca/test/store-function/store-ui.hpp Sat Oct  3 21:50:40 2009
@@ -33,30 +33,30 @@
 {
 
 const tuscany::list<ItemType> storeUI_getCatalog(const service& catalog) {
-    return catalog(makeList(tuscany::value("get")));
+    return catalog(tuscany::makeList<tuscany::value>("get"));
 }
 
 const tuscany::list<ItemType> storeUI_getCart(const service& cart) {
-    return cart(makeList(tuscany::value("getAll")));
+    return cart(tuscany::makeList<tuscany::value>("getAll"));
 }
 
 const double storeUI_getTotal(const service& cart) {
-    return cart(makeList(tuscany::value("getTotal")));
+    return cart(tuscany::makeList<tuscany::value>("getTotal"));
 }
 
 const bool storeUI_post(const service& cart, const ItemType& item) {
-    return cart(makeList(tuscany::value("post"), tuscany::value(item)));
+    return cart(tuscany::makeList<tuscany::value>("post", item));
 }
 
 const tuscany::value storeUI_service(const service& catalog, const service& cart, const tuscany::list<tuscany::value>& args) {
-    if (car(args) == tuscany::value("getCatalog"))
-        return tuscany::value(storeUI_getCatalog(catalog));
-    if (car(args) == tuscany::value("getCart"))
-        return tuscany::value(storeUI_getCart(cart));
-    if (car(args) == tuscany::value("getTotal"))
-        return tuscany::value(storeUI_getTotal(cart));
-    if (car(args) == tuscany::value("post"))
-        return tuscany::value(storeUI_post(cart, cadr(args)));
+    if (car(args) == "getCatalog")
+        return storeUI_getCatalog(catalog);
+    if (car(args) == "getCart")
+        return storeUI_getCart(cart);
+    if (car(args) == "getTotal")
+        return storeUI_getTotal(cart);
+    if (car(args) == "post")
+        return storeUI_post(cart, cadr(args));
     return tuscany::value();
 }