You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/07 20:54:09 UTC
[GitHub] [spark] joshrosen-stripe commented on issue #25971:
[SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver
endpoint
joshrosen-stripe commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint
URL: https://github.com/apache/spark/pull/25971#issuecomment-539199818
Does this change introduce any potential race-conditions in the case where we detect a legitimate timeout? For example, are there any situations where previously the "mark block manager as dead" was performed serially w.r.t. other block manager operations but now can be performed in parallel?
I haven't looked closely at this patch yet, so maybe this concern is already addressed / is not an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org