You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/24 21:59:45 UTC
Review Request: SQOOP-667 We should persist in repository all properties of
MSubmission metadata class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8206/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've enhanced Derby repository to store all fields of MSubmission metadata object.
This addresses bug SQOOP-667.
https://issues.apache.org/jira/browse/SQOOP-667
Diffs
-----
common/src/main/java/org/apache/sqoop/submission/counter/Counters.java 12c9464341810280cef0ba027adbe4545acdf62a
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 90aef4ba64328301943af66a027aa55564e9e290
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 3664df6e473d3062c8ebffd8493347c34bdda2c7
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 496e3d9e902268629d9785a45f11c51a1cddd7fe
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 7aa362e45233690076eabc2346c7d16c4b3b3c46
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 3433b20fa6133d3dc50c33447021cf69955295b4
Diff: https://reviews.apache.org/r/8206/diff/
Testing
-------
I've provided quite extensive test coverage.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-667 We should persist in repository all properties
of MSubmission metadata class
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8206/#review13731
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Nov. 24, 2012, 8:59 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8206/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2012, 8:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've enhanced Derby repository to store all fields of MSubmission metadata object.
>
>
> This addresses bug SQOOP-667.
> https://issues.apache.org/jira/browse/SQOOP-667
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/submission/counter/Counters.java 12c9464341810280cef0ba027adbe4545acdf62a
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 90aef4ba64328301943af66a027aa55564e9e290
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 3664df6e473d3062c8ebffd8493347c34bdda2c7
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 496e3d9e902268629d9785a45f11c51a1cddd7fe
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 7aa362e45233690076eabc2346c7d16c4b3b3c46
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 3433b20fa6133d3dc50c33447021cf69955295b4
>
> Diff: https://reviews.apache.org/r/8206/diff/
>
>
> Testing
> -------
>
> I've provided quite extensive test coverage.
>
>
> Thanks,
>
> Jarek Cecho
>
>