You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2020/06/22 15:43:00 UTC

[jira] [Commented] (ARROW-9188) [C++] Do not always statically link Brotli libraries

    [ https://issues.apache.org/jira/browse/ARROW-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142195#comment-17142195 ] 

Antoine Pitrou commented on ARROW-9188:
---------------------------------------

Well, I'm not sure it's a good idea to disable Brotli and make some Parquet files unreadable (I suppose it's mainly used in Parquet, right?).

> [C++] Do not always statically link Brotli libraries
> ----------------------------------------------------
>
>                 Key: ARROW-9188
>                 URL: https://issues.apache.org/jira/browse/ARROW-9188
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: 1.0.0
>
>
> I discovered by symbol sleuthing that even if the Brotli shared libraries are available on the system, the static libraries will be used for linking. Here's a dump of the symbols on my machine
> https://gist.github.com/wesm/b7e911424ce3ca3a175b652666fe6f89
> The largest of these symbols {{kBrotliDictionaryData}} is 120KB
> Since we statically link everything in our Python wheels, we might consider disabling Brotli in manylinux builds at least since it adds 800KB to libarrow.so



--
This message was sent by Atlassian Jira
(v8.3.4#803005)