You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/05 09:45:22 UTC

[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #19614: [BUGFIX] Fix backward pass for nested CachedOp

mseth10 commented on a change in pull request #19614:
URL: https://github.com/apache/incubator-mxnet/pull/19614#discussion_r536620855



##########
File path: src/imperative/cached_op.cc
##########
@@ -327,9 +327,10 @@ bool CachedOp::SetBackwardGraph(
   node_range = {num_forward_nodes, idx.num_nodes()};
   entry_range = {num_forward_entries, idx.num_node_entries()};
 
+  bool contain_dynamic_shape = false;

Review comment:
       why do we need this? this variable is not used in this function.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org