You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2015/01/09 03:53:32 UTC
Review Request 29751: Patch for kafka-1851
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29751/
-----------------------------------------------------------
Review request for kafka.
Bugs: kafka-1851
https://issues.apache.org/jira/browse/kafka-1851
Repository: kafka
Description
-------
fix the behavior of OffsetFetchRequest on unknown partition
Diffs
-----
core/src/main/scala/kafka/server/KafkaApis.scala 2f009920af37de3cf0a3eb131f2124f4e532c4e4
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/29751/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 29751: Patch for kafka-1851
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29751/#review67476
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Jan. 9, 2015, 2:53 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29751/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 2:53 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1851
> https://issues.apache.org/jira/browse/kafka-1851
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix the behavior of OffsetFetchRequest on unknown partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 2f009920af37de3cf0a3eb131f2124f4e532c4e4
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
>
> Diff: https://reviews.apache.org/r/29751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 29751: Patch for kafka-1851
Posted by Jun Rao <ju...@gmail.com>.
> On Jan. 9, 2015, 8:01 p.m., Ewen Cheslack-Postava wrote:
> > core/src/main/scala/kafka/server/KafkaApis.scala, line 512
> > <https://reviews.apache.org/r/29751/diff/1/?file=813957#file813957line512>
> >
> > You could just change getOffsets so it doesn't have this behavior instead of checking the condition here. It looks like this is the only place it's called from so nothing else should be relying on that behavior and it just simplifies the getOffsets code.
Yes, I wasn't sure if there will be a use case to get the offsets of all partitions in the same consumer group.
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29751/#review67499
-----------------------------------------------------------
On Jan. 9, 2015, 2:53 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29751/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 2:53 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1851
> https://issues.apache.org/jira/browse/kafka-1851
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix the behavior of OffsetFetchRequest on unknown partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 2f009920af37de3cf0a3eb131f2124f4e532c4e4
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
>
> Diff: https://reviews.apache.org/r/29751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 29751: Patch for kafka-1851
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29751/#review67499
-----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/29751/#comment111536>
You could just change getOffsets so it doesn't have this behavior instead of checking the condition here. It looks like this is the only place it's called from so nothing else should be relying on that behavior and it just simplifies the getOffsets code.
- Ewen Cheslack-Postava
On Jan. 9, 2015, 2:53 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29751/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 2:53 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1851
> https://issues.apache.org/jira/browse/kafka-1851
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix the behavior of OffsetFetchRequest on unknown partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala 2f009920af37de3cf0a3eb131f2124f4e532c4e4
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
>
> Diff: https://reviews.apache.org/r/29751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>