You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stephan202 (via GitHub)" <gi...@apache.org> on 2023/04/29 14:42:19 UTC
[GitHub] [maven-enforcer] Stephan202 opened a new pull request, #269: [MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Stephan202 opened a new pull request, #269:
URL: https://github.com/apache/maven-enforcer/pull/269
Suggested commit message:
```
[MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Matching artifacts should be _excluded_ rather than included.
```
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #269: [MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #269:
URL: https://github.com/apache/maven-enforcer/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #269: [MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #269:
URL: https://github.com/apache/maven-enforcer/pull/269#discussion_r1181275926
##########
maven-enforcer-plugin/src/it/projects/ban-dynamic-versions/pom.xml:
##########
@@ -109,6 +112,12 @@
<!-- version range syntax with equal upper and lower bounds -->
<version>[1.0]</version>
</dependency>
+ <dependency>
+ <!-- banned transitive version range, but ignored -->
+ <groupId>org.apache.maven.plugins.enforcer.its</groupId>
+ <artifactId>menforcer480</artifactId>
Review Comment:
new test artifact? I don't see it in PR ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #269: [MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #269:
URL: https://github.com/apache/maven-enforcer/pull/269#discussion_r1181280169
##########
maven-enforcer-plugin/src/it/projects/ban-dynamic-versions/pom.xml:
##########
@@ -109,6 +112,12 @@
<!-- version range syntax with equal upper and lower bounds -->
<version>[1.0]</version>
</dependency>
+ <dependency>
+ <!-- banned transitive version range, but ignored -->
+ <groupId>org.apache.maven.plugins.enforcer.its</groupId>
+ <artifactId>menforcer480</artifactId>
Review Comment:
If any existing artifact meet your requirement you can reuse, if no please create new
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] Stephan202 commented on a diff in pull request #269: [MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Posted by "Stephan202 (via GitHub)" <gi...@apache.org>.
Stephan202 commented on code in PR #269:
URL: https://github.com/apache/maven-enforcer/pull/269#discussion_r1181277447
##########
maven-enforcer-plugin/src/it/projects/ban-dynamic-versions/pom.xml:
##########
@@ -109,6 +112,12 @@
<!-- version range syntax with equal upper and lower bounds -->
<version>[1.0]</version>
</dependency>
+ <dependency>
+ <!-- banned transitive version range, but ignored -->
+ <groupId>org.apache.maven.plugins.enforcer.its</groupId>
+ <artifactId>menforcer480</artifactId>
Review Comment:
Ah, I misunderstood this setup. I now see the `repository` dir. Will reuse of the of existing ones and push a commit in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] Stephan202 commented on a diff in pull request #269: [MENFORCER-480] BanDynamicVersions: fix `ignores` parameter
Posted by "Stephan202 (via GitHub)" <gi...@apache.org>.
Stephan202 commented on code in PR #269:
URL: https://github.com/apache/maven-enforcer/pull/269#discussion_r1181281103
##########
maven-enforcer-plugin/src/it/projects/ban-dynamic-versions/pom.xml:
##########
@@ -109,6 +112,12 @@
<!-- version range syntax with equal upper and lower bounds -->
<version>[1.0]</version>
</dependency>
+ <dependency>
+ <!-- banned transitive version range, but ignored -->
+ <groupId>org.apache.maven.plugins.enforcer.its</groupId>
+ <artifactId>menforcer480</artifactId>
Review Comment:
Rebased and added a commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org