You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/04/20 14:37:00 UTC
[jira] [Commented] (PROTON-2716) Warnings from opentelemetry-cpp propagate up and stop a -Werror build on Fedora 38 using vcpkg to get opentelemetry-cpp[jaeger]
[ https://issues.apache.org/jira/browse/PROTON-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714623#comment-17714623 ]
ASF subversion and git services commented on PROTON-2716:
---------------------------------------------------------
Commit a60ca6edc5028e42a7d3f40ff5a393a14d92d6c2 in qpid-proton's branch refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=a60ca6edc ]
PROTON-2716: replace `include_directories()` call with opentelemetry-cpp provided targets (#394)
> Warnings from opentelemetry-cpp propagate up and stop a -Werror build on Fedora 38 using vcpkg to get opentelemetry-cpp[jaeger]
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: PROTON-2716
> URL: https://issues.apache.org/jira/browse/PROTON-2716
> Project: Qpid Proton
> Issue Type: Bug
> Components: build, cpp-binding, examples
> Affects Versions: proton-c-0.39.0
> Reporter: Jiri Daněk
> Priority: Major
>
> MSVC apparently tried something to exclude 3rd party libs from strict compilation warning settings, https://devblogs.microsoft.com/cppblog/broken-warnings-theory/, and gcc/cmake should have this too, all IMPORTED targets include directories with -isystem, which should suppress excessive warnings https://stackoverflow.com/a/73549820/1047788..
> Aand, I think I found it, we have
> {noformat}
> if (ENABLE_OPENTELEMETRYCPP)
> include_directories(${OPENTELEMETRY_CPP_INCLUDE_DIRS})
> {noformat}
> so we are preempting what I described above by pulling these dirs into the project on our own without CMake mediation! When this line (include_directories) is deleted, then the Clang build starts working.
> This change sillences compile errors such as
> {noformat}
> In file included from /home/jdanek/repos/qpid/qpid-proton/cmake-build-debug-clang/vcpkg_installed/x64-linux/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/invoke.h:42:
> /home/jdanek/repos/qpid/qpid-proton/cmake-build-debug-clang/vcpkg_installed/x64-linux/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:299:36: error: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Werror,-Wdeprecated-builtins]
> : std::integral_constant<bool, __has_trivial_destructor(T) &&
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org