You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2010/04/23 14:16:50 UTC
[jira] Created: (LUCENE-2415) Remove JakarteRegExCapabilities shim
to access package protected field
Remove JakarteRegExCapabilities shim to access package protected field
----------------------------------------------------------------------
Key: LUCENE-2415
URL: https://issues.apache.org/jira/browse/LUCENE-2415
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/*
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 3.1
To access the prefix in Jakarta RegExes we use a shim class in the same package as jakarta. I will remove this and replace by reflection like Robert does in his ICUTokenizer rule compiler.
Shim classes have the problem wth signed artifacts, as you cannot insert a new class into a foreign package if you sign regex classes.
This shim-removal also allows users to use later jakarta regex versions, if they are in classpath and cannot be removed (even if they have bugs). Performance is no problem, as the prefix is only get once per TermEnum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2415) Remove JakarteRegExCapabilities shim
to access package protected field
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2415:
----------------------------------
Attachment: LUCENE-2415.patch
> Remove JakarteRegExCapabilities shim to access package protected field
> ----------------------------------------------------------------------
>
> Key: LUCENE-2415
> URL: https://issues.apache.org/jira/browse/LUCENE-2415
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.1
>
> Attachments: LUCENE-2415.patch
>
>
> To access the prefix in Jakarta RegExes we use a shim class in the same package as jakarta. I will remove this and replace by reflection like Robert does in his ICUTokenizer rule compiler.
> Shim classes have the problem wth signed artifacts, as you cannot insert a new class into a foreign package if you sign regex classes.
> This shim-removal also allows users to use later jakarta regex versions, if they are in classpath and cannot be removed (even if they have bugs). Performance is no problem, as the prefix is only get once per TermEnum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2415) Remove JakarteRegExCapabilities
shim to access package protected field
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860237#action_12860237 ]
Robert Muir commented on LUCENE-2415:
-------------------------------------
+1
> Remove JakarteRegExCapabilities shim to access package protected field
> ----------------------------------------------------------------------
>
> Key: LUCENE-2415
> URL: https://issues.apache.org/jira/browse/LUCENE-2415
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.1
>
> Attachments: LUCENE-2415.patch
>
>
> To access the prefix in Jakarta RegExes we use a shim class in the same package as jakarta. I will remove this and replace by reflection like Robert does in his ICUTokenizer rule compiler.
> Shim classes have the problem wth signed artifacts, as you cannot insert a new class into a foreign package if you sign regex classes.
> This shim-removal also allows users to use later jakarta regex versions, if they are in classpath and cannot be removed (even if they have bugs). Performance is no problem, as the prefix is only get once per TermEnum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2415) Remove JakarteRegExCapabilities
shim to access package protected field
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860235#action_12860235 ]
Uwe Schindler commented on LUCENE-2415:
---------------------------------------
Will commit this later this evening if nobody objects!
> Remove JakarteRegExCapabilities shim to access package protected field
> ----------------------------------------------------------------------
>
> Key: LUCENE-2415
> URL: https://issues.apache.org/jira/browse/LUCENE-2415
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.1
>
> Attachments: LUCENE-2415.patch
>
>
> To access the prefix in Jakarta RegExes we use a shim class in the same package as jakarta. I will remove this and replace by reflection like Robert does in his ICUTokenizer rule compiler.
> Shim classes have the problem wth signed artifacts, as you cannot insert a new class into a foreign package if you sign regex classes.
> This shim-removal also allows users to use later jakarta regex versions, if they are in classpath and cannot be removed (even if they have bugs). Performance is no problem, as the prefix is only get once per TermEnum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2415) Remove JakarteRegExCapabilities shim
to access package protected field
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-2415.
-----------------------------------
Resolution: Fixed
Committed revision: 937360
> Remove JakarteRegExCapabilities shim to access package protected field
> ----------------------------------------------------------------------
>
> Key: LUCENE-2415
> URL: https://issues.apache.org/jira/browse/LUCENE-2415
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.1
>
> Attachments: LUCENE-2415.patch
>
>
> To access the prefix in Jakarta RegExes we use a shim class in the same package as jakarta. I will remove this and replace by reflection like Robert does in his ICUTokenizer rule compiler.
> Shim classes have the problem wth signed artifacts, as you cannot insert a new class into a foreign package if you sign regex classes.
> This shim-removal also allows users to use later jakarta regex versions, if they are in classpath and cannot be removed (even if they have bugs). Performance is no problem, as the prefix is only get once per TermEnum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org