You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/04 04:38:06 UTC
[GitHub] [flink] leonardBang commented on a change in pull request #18966: [FLINK-26422][docs-zh][table]update chinese doc with the new TablePipeline docs
leonardBang commented on a change in pull request #18966:
URL: https://github.com/apache/flink/pull/18966#discussion_r819257593
##########
File path: docs/content.zh/docs/dev/table/common.md
##########
@@ -645,7 +645,10 @@ Table API 和 SQL 查询的混用非常简单因为它们都返回 `Table` 对
请参考文档 [Table Sources & Sinks]({{< ref "docs/dev/table/sourcesSinks" >}}) 以获取更多关于可用 Sink 的信息以及如何自定义 `DynamicTableSink`。
-方法 `Table.executeInsert(String tableName)` 将 `Table` 发送至已注册的 `TableSink`。该方法通过名称在 catalog 中查找 `TableSink` 并确认`Table` schema 和 `TableSink` schema 一致。
+方法 `Table.insertInto(String tableName)` 定义了一个完整的端到端管道将源表中的数据传输到一个被注册的输出表中。
+
Review comment:
minor: no need blank line
##########
File path: docs/content.zh/docs/dev/table/common.md
##########
@@ -910,10 +925,10 @@ tEnv.createTemporaryTable("MySink2", TableDescriptor.forConnector("filesystem")
StatementSet stmtSet = tEnv.createStatementSet();
Table table1 = tEnv.from("MySource1").where($("word").like("F%"));
-stmtSet.addInsert("MySink1", table1);
+stmtSet.add(table1.insertInto("MySink1");
Review comment:
```suggestion
stmtSet.add(table1.insertInto("MySink1"));
```
please also help add the missed `)` in English document
##########
File path: docs/content.zh/docs/dev/table/common.md
##########
@@ -910,10 +925,10 @@ tEnv.createTemporaryTable("MySink2", TableDescriptor.forConnector("filesystem")
StatementSet stmtSet = tEnv.createStatementSet();
Table table1 = tEnv.from("MySource1").where($("word").like("F%"));
-stmtSet.addInsert("MySink1", table1);
+stmtSet.add(table1.insertInto("MySink1");
Table table2 = table1.unionAll(tEnv.from("MySource2"));
-stmtSet.addInsert("MySink2", table2);
+stmtSet.add(table2.insertInto("MySink2");
Review comment:
```suggestion
stmtSet.add(table2.insertInto("MySink2"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org