You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2014/08/21 10:43:33 UTC
[Bug 56877] New: CSVDataSet does not trim spaces in .csv
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
Bug ID: 56877
Summary: CSVDataSet does not trim spaces in <filename>.csv
Product: JMeter
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: dzmitry.kashlach@blazemeter.com
Created attachment 31936
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31936&action=edit
csv_dataset.patch
CSVDataSet does not trim spaces in <filename>.csv
E.g. if user entered in text-box "<filename>.csv ", then filename will be set
as
"<filename>.csv " but not "<filename>.csv".
I suggest simple patch for it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #7 from Dzmitry Kashlach <dz...@blazemeter.com> ---
(In reply to Philippe Mouawad from comment #6)
> To be clean, I think we should look at all elements that use FileNames and
> add trimming (not only to 2 elements).
Agree. But here is a little dilemma for me: either to fix two elements(which
use FileServer, CSVDataSet&TCLogParser), or make deep fix, which you've already
rejected(trimm all StringProperties in
TestBeanHelper&GenericTestBeanCustomizer).
Do you know any intermediate variant?
>Also, for cleanness, I suggest setter are not modified, only the code that uses >fileName should trim it.
I think, it could be better to trim filename higher than fileserver level,
because filename is used also as alias. In this case we'll do far less changes
in code.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
Thanks for contribution.
To be clean, I think we should look at all elements that use FileNames and add
trimming (not only to 2 elements).
Also, for cleanness, I suggest setter are not modified, only the code that uses
fileName should trim it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #1 from Andrey Pohilko <ap...@ya.ru> ---
Maybe this is better be fixed in org.apache.jmeter.services.FileServer class to
have the effect everywhere.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #4 from Dzmitry Kashlach <dz...@blazemeter.com> ---
Third variant is to fix CSVDataSet and TCLogParser, because they both reserve
files using FilerServer. In this case patch may look like latest one in
attachement.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
I think the fix of last patch is too coarse and impacting as it hits much more
than simple path in Beans.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #5 from Dzmitry Kashlach <dz...@blazemeter.com> ---
Created attachment 31940
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31940&action=edit
CSVDataSet&TCLogParser
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hi,
I rejected the trim on all StringProperties in
TestBeanHelper&GenericTestBeanCustomizer as it would have affected also non
filenames which may have side effects for existing plans.
The best thing IMHO is to review all components that have filenames and trim
spaces for them.
It is more work but I think it is more coherent.
Regards
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Linux |All
Severity|normal |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56877] CSVDataSet does not trim spaces in .csv
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56877
--- Comment #2 from Dzmitry Kashlach <dz...@blazemeter.com> ---
Created attachment 31939
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31939&action=edit
TestBeanHelper&GenericTestBeanCustomizer
I've made some more research and tried to fixed this issue for all String
properties wherever they occur.
--
You are receiving this mail because:
You are the assignee for the bug.