You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/23 03:31:22 UTC

[GitHub] [dubbo] AlbumenJ opened a new pull request #8884: Fix #8843, recover Servlet Page API

AlbumenJ opened a new pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884


   ## What is the purpose of the change
   
   
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884#issuecomment-925496873


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8884](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (690aa84) into [3.0](https://codecov.io/gh/apache/dubbo/commit/00ea21c55ea011b0a5eb957fbf36c8f1ed079547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00ea21c) will **decrease** coverage by `0.59%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8884/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8884      +/-   ##
   ============================================
   - Coverage     63.77%   63.18%   -0.60%     
   + Complexity      314      311       -3     
   ============================================
     Files          1169     1177       +8     
     Lines         49247    49627     +380     
     Branches       7368     7413      +45     
   ============================================
   - Hits          31408    31355      -53     
   - Misses        14415    14837     +422     
   - Partials       3424     3435      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...m/alibaba/dubbo/container/page/MenuComparator.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL01lbnVDb21wYXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/java/com/alibaba/dubbo/container/page/Page.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../com/alibaba/dubbo/container/page/PageServlet.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2VTZXJ2bGV0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/alibaba/dubbo/container/page/ResourceFilter.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1Jlc291cmNlRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ba/dubbo/container/page/pages/HomePageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0hvbWVQYWdlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...aba/dubbo/container/page/pages/LogPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0xvZ1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/StatusPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N0YXR1c1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/SystemPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N5c3RlbVBhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `59.25% <0.00%> (-14.82%)` | :arrow_down: |
   | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75.00% <0.00%> (-12.50%)` | :arrow_down: |
   | ... and [54 more](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00ea21c...690aa84](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884#issuecomment-925496873


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8884](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (690aa84) into [3.0](https://codecov.io/gh/apache/dubbo/commit/00ea21c55ea011b0a5eb957fbf36c8f1ed079547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00ea21c) will **decrease** coverage by `0.52%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8884/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8884      +/-   ##
   ============================================
   - Coverage     63.89%   63.36%   -0.53%     
   + Complexity      315      313       -2     
   ============================================
     Files          1169     1177       +8     
     Lines         49247    49663     +416     
     Branches       7368     7440      +72     
   ============================================
   + Hits          31467    31470       +3     
   - Misses        14360    14778     +418     
   + Partials       3420     3415       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...m/alibaba/dubbo/container/page/MenuComparator.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL01lbnVDb21wYXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/java/com/alibaba/dubbo/container/page/Page.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../com/alibaba/dubbo/container/page/PageServlet.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2VTZXJ2bGV0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/alibaba/dubbo/container/page/ResourceFilter.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1Jlc291cmNlRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ba/dubbo/container/page/pages/HomePageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0hvbWVQYWdlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...aba/dubbo/container/page/pages/LogPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0xvZ1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/StatusPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N0YXR1c1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/SystemPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N5c3RlbVBhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `82.05% <0.00%> (-5.13%)` | :arrow_down: |
   | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0.00%> (-4.55%)` | :arrow_down: |
   | ... and [25 more](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00ea21c...690aa84](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884#issuecomment-925496873


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8884](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (690aa84) into [3.0](https://codecov.io/gh/apache/dubbo/commit/00ea21c55ea011b0a5eb957fbf36c8f1ed079547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00ea21c) will **decrease** coverage by `0.53%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8884/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8884      +/-   ##
   ============================================
   - Coverage     63.77%   63.24%   -0.54%     
   + Complexity      314      312       -2     
   ============================================
     Files          1169     1177       +8     
     Lines         49247    49663     +416     
     Branches       7368     7440      +72     
   ============================================
   + Hits          31408    31410       +2     
   - Misses        14415    14828     +413     
   - Partials       3424     3425       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...m/alibaba/dubbo/container/page/MenuComparator.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL01lbnVDb21wYXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/java/com/alibaba/dubbo/container/page/Page.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../com/alibaba/dubbo/container/page/PageServlet.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2VTZXJ2bGV0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/alibaba/dubbo/container/page/ResourceFilter.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1Jlc291cmNlRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ba/dubbo/container/page/pages/HomePageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0hvbWVQYWdlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...aba/dubbo/container/page/pages/LogPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0xvZ1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/StatusPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N0YXR1c1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/SystemPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N5c3RlbVBhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `82.05% <0.00%> (-5.13%)` | :arrow_down: |
   | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.54% <0.00%> (-4.55%)` | :arrow_down: |
   | ... and [26 more](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00ea21c...690aa84](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884#issuecomment-925496873


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8884](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (690aa84) into [3.0](https://codecov.io/gh/apache/dubbo/commit/00ea21c55ea011b0a5eb957fbf36c8f1ed079547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00ea21c) will **decrease** coverage by `0.55%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8884/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8884      +/-   ##
   ============================================
   - Coverage     63.89%   63.33%   -0.56%     
   + Complexity      315      313       -2     
   ============================================
     Files          1169     1177       +8     
     Lines         49247    49663     +416     
     Branches       7368     7440      +72     
   ============================================
   - Hits          31467    31455      -12     
   - Misses        14360    14791     +431     
   + Partials       3420     3417       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...m/alibaba/dubbo/container/page/MenuComparator.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL01lbnVDb21wYXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/java/com/alibaba/dubbo/container/page/Page.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../com/alibaba/dubbo/container/page/PageServlet.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2VTZXJ2bGV0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/alibaba/dubbo/container/page/ResourceFilter.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1Jlc291cmNlRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ba/dubbo/container/page/pages/HomePageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0hvbWVQYWdlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...aba/dubbo/container/page/pages/LogPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0xvZ1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/StatusPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N0YXR1c1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/SystemPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N5c3RlbVBhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `82.05% <0.00%> (-5.13%)` | :arrow_down: |
   | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0.00%> (-4.55%)` | :arrow_down: |
   | ... and [24 more](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00ea21c...690aa84](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884#issuecomment-925496873


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8884](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (690aa84) into [3.0](https://codecov.io/gh/apache/dubbo/commit/00ea21c55ea011b0a5eb957fbf36c8f1ed079547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00ea21c) will **decrease** coverage by `0.48%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8884/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8884      +/-   ##
   ============================================
   - Coverage     63.89%   63.40%   -0.49%     
   + Complexity      315      314       -1     
   ============================================
     Files          1169     1177       +8     
     Lines         49247    49663     +416     
     Branches       7368     7440      +72     
   ============================================
   + Hits          31467    31491      +24     
   - Misses        14360    14758     +398     
   + Partials       3420     3414       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...m/alibaba/dubbo/container/page/MenuComparator.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL01lbnVDb21wYXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/java/com/alibaba/dubbo/container/page/Page.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../com/alibaba/dubbo/container/page/PageServlet.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2VTZXJ2bGV0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/alibaba/dubbo/container/page/ResourceFilter.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1Jlc291cmNlRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ba/dubbo/container/page/pages/HomePageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0hvbWVQYWdlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...aba/dubbo/container/page/pages/LogPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0xvZ1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/StatusPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N0YXR1c1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/SystemPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N5c3RlbVBhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0.00%> (-4.55%)` | :arrow_down: |
   | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `63.04% <0.00%> (-4.35%)` | :arrow_down: |
   | ... and [21 more](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00ea21c...690aa84](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884#issuecomment-925496873


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8884](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (690aa84) into [3.0](https://codecov.io/gh/apache/dubbo/commit/00ea21c55ea011b0a5eb957fbf36c8f1ed079547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00ea21c) will **decrease** coverage by `0.56%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8884/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8884      +/-   ##
   ============================================
   - Coverage     63.89%   63.33%   -0.57%     
   + Complexity      315      313       -2     
   ============================================
     Files          1169     1177       +8     
     Lines         49247    49663     +416     
     Branches       7368     7440      +72     
   ============================================
   - Hits          31467    31453      -14     
   - Misses        14360    14791     +431     
   + Partials       3420     3419       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...m/alibaba/dubbo/container/page/MenuComparator.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL01lbnVDb21wYXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/java/com/alibaba/dubbo/container/page/Page.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../com/alibaba/dubbo/container/page/PageServlet.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1BhZ2VTZXJ2bGV0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/alibaba/dubbo/container/page/ResourceFilter.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL1Jlc291cmNlRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ba/dubbo/container/page/pages/HomePageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0hvbWVQYWdlSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...aba/dubbo/container/page/pages/LogPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL0xvZ1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/StatusPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N0YXR1c1BhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../dubbo/container/page/pages/SystemPageHandler.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbnRhaW5lci9wYWdlL3BhZ2VzL1N5c3RlbVBhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `82.05% <0.00%> (-5.13%)` | :arrow_down: |
   | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0.00%> (-4.55%)` | :arrow_down: |
   | ... and [25 more](https://codecov.io/gh/apache/dubbo/pull/8884/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00ea21c...690aa84](https://codecov.io/gh/apache/dubbo/pull/8884?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8884: Fix #8843, recover Servlet Page API

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8884:
URL: https://github.com/apache/dubbo/pull/8884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org