Re: [PR] [SPARK-47395] Add collate and collation to other APIs [spark]

["dbatomic (via GitHub)" <gi...@apache.org>]

dbatomic commented on code in PR #45517:
URL: https://github.com/apache/spark/pull/45517#discussion_r1525097586


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -4845,6 +4845,10 @@ object functions {
       otherChar: Column): Column =
     Column.fn("mask", input, upperChar, lowerChar, digitChar, otherChar)
 
+  def collate(e: Column, collation: String): Column = Column.fn("collate", e, lit(collation))

Review Comment:
   We should add proper comment header here since this is public API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org