You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by zh...@apache.org on 2018/03/14 19:55:31 UTC

[2/3] mesos git commit: Added a test to make sure `slave/recovery_time_secs` is reported.

Added a test to make sure `slave/recovery_time_secs` is reported.

Review: https://reviews.apache.org/r/65959


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b8526c61
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b8526c61
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b8526c61

Branch: refs/heads/master
Commit: b8526c61403214aaa67fa941b4e8b0fd8e3328f2
Parents: 026dafd
Author: Zhitao Li <zh...@gmail.com>
Authored: Wed Mar 7 15:18:53 2018 -0800
Committer: Zhitao Li <zh...@gmail.com>
Committed: Wed Mar 14 12:54:54 2018 -0700

----------------------------------------------------------------------
 src/tests/slave_tests.cpp | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/b8526c61/src/tests/slave_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp
index c2afaa5..f76500e 100644
--- a/src/tests/slave_tests.cpp
+++ b/src/tests/slave_tests.cpp
@@ -1374,12 +1374,19 @@ TEST_F(SlaveTest, MetricsInMetricsEndpoint)
   Try<Owned<cluster::Slave>> slave = StartSlave(detector.get());
   ASSERT_SOME(slave);
 
+  // Make sure slave finishes recovery.
+  Future<RegisterSlaveMessage> registerSlave = FUTURE_PROTOBUF(
+      RegisterSlaveMessage(), slave.get()->pid, master.get()->pid);
+
+  AWAIT_READY(registerSlave);
+
   JSON::Object snapshot = Metrics();
 
   EXPECT_EQ(1u, snapshot.values.count("slave/uptime_secs"));
   EXPECT_EQ(1u, snapshot.values.count("slave/registered"));
 
   EXPECT_EQ(1u, snapshot.values.count("slave/recovery_errors"));
+  EXPECT_EQ(1u, snapshot.values.count("slave/recovery_time_secs"));
 
   EXPECT_EQ(1u, snapshot.values.count("slave/frameworks_active"));