You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/31 14:55:03 UTC
[GitHub] flink pull request #4035: [FLINK-6785] [metrics] Fix ineffective asserts in ...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4035
[FLINK-6785] [metrics] Fix ineffective asserts in MetricRegistryTest
Asserts inside reporters are not inherently effective to detect test failures, so I moved the asserts outside and access the required information via static fields.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4035.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4035
----
commit 5e0d4a397e510f0b0d70e656819592ed52e855d2
Author: zentol <ch...@apache.org>
Date: 2017-05-31T14:49:43Z
[FLINK-6785] [metrics] Fix ineffective asserts in MetricRegistryTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4035: [FLINK-6785] [metrics] Fix ineffective asserts in MetricR...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4035
change looks good but fails the new checkstyle rules:
```
[INFO] There are 4 errors reported by Checkstyle 6.19 with /tools/maven/strict-checkstyle.xml ruleset.
[ERROR] src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[256] (whitespace) EmptyLineSeparator: There is more than 1 empty line one after another.
[ERROR] src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[259] (regexp) RegexpSingleline: Trailing whitespace
[ERROR] src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[265] (whitespace) EmptyLineSeparator: There is more than 1 empty line one after another.
[ERROR] src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[278] (regexp) RegexpSingleline: Trailing whitespace
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4035: [FLINK-6785] [metrics] Fix ineffective asserts in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4035: [FLINK-6785] [metrics] Fix ineffective asserts in MetricR...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4035
I've resolved the checkstyle issues and will start merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---