[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator

["Hervé Boutemy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712588#comment-14712588 ] 

Hervé Boutemy edited comment on MRELEASE-899 at 8/26/15 6:32 AM:
-----------------------------------------------------------------

every SCM I know of has a feature to use system newlines: then the same file has Windows newline when checked out on Windows or Linux newline when checked out on Linux
this is a good practice, just to avoid such problems at every level: for example use of an editor that don't support newline detection to edit consistently

adding such a feature in release plugin would make the code more complex and help a bad practice that should be treated at source control management level


was (Author: hboutemy):
every SCN I know of has a feature to use system newlines: then the same file has Windows newline when checked out on Windows or Linux newline when checked out on Linux
this is a good practice, just to avoid such problems at every level: for example use of an editor that don't support newline detection to edit consistently

adding such a feature in release plugin would make the code more complex and help a bad practice that should be treated at source control management level

> release:prepare should not change the line separator
> ----------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)