You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/28 14:49:56 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2941: [Imporve][api] customize operator parallel
liugddx opened a new pull request, #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941
close #2925
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
customize operator parallel
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#issuecomment-1280273472
> Can you add spark for support this parameter too? Because you put `parallelism` into common-options, but spark not support.
Done. @EricJoy2048 @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#discussion_r990599407
##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/resources/examples/fake_to_console.conf:
##########
@@ -53,8 +53,10 @@ transform {
}
sink {
- Console {}
+ Console {
+ execution.parallelism = 3
Review Comment:
I suggest we use the unified parameters `parallelism `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#discussion_r994317766
##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SinkExecuteProcessor.java:
##########
@@ -76,7 +78,11 @@ public List<DataStream<Row>> execute(List<DataStream<Row>> upstreamDataStreams)
SeaTunnelSink<SeaTunnelRow, Serializable, Serializable, Serializable> seaTunnelSink = plugins.get(i);
DataStream<Row> stream = fromSourceTable(sinkConfig).orElse(input);
seaTunnelSink.setTypeInfo((SeaTunnelRowType) TypeConverterUtils.convert(stream.getType()));
- stream.sinkTo(new FlinkSink<>(seaTunnelSink)).name(seaTunnelSink.getPluginName());
+ DataStreamSink<Row> dataStreamSink = stream.sinkTo(new FlinkSink<>(seaTunnelSink)).name(seaTunnelSink.getPluginName());
Review Comment:
How to support spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink and spark
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#issuecomment-1279754895
@ashulin help to review thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2941: [Imporve][api] customize operator parallel
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#issuecomment-1263071830
great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#issuecomment-1280222916
Can you add spark for support this parameter too? Because you put `parallelism` into common-options, but spark not support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#discussion_r990940603
##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/resources/examples/fake_to_console.conf:
##########
@@ -28,33 +28,35 @@ env {
source {
# This is a example source plugin **only for test and demonstrate the feature source plugin**
- FakeSource {
- result_table_name = "fake"
- row.num = 16
- schema = {
- fields {
- name = "string"
- age = "int"
- }
+ FakeSource {
Review Comment:
Please add parallelism config in FakeSource. Also please update doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2941: [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2941:
URL: https://github.com/apache/incubator-seatunnel/pull/2941#issuecomment-1278966004
@Hisoka-X PTALthanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org