You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/28 15:39:00 UTC
[GitHub] [superset] srinify edited a comment on pull request #12710: docs: Add support for Hologres
srinify edited a comment on pull request #12710:
URL: https://github.com/apache/superset/pull/12710#issuecomment-769150103
@TimothyDing thank you for contributing this and welcome to the community!
I tested documentation locally and the logo rendered just fine. This is optional, but can you remove the trailing `,` in the last element of `docs/src/resources/data.js`. This still seems to work, but it's technically not valid JavaScript! (Only the first to `n-1` elements in a list object in Javascript should have a trailing comma `,`, but not the `n` element!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org