You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by abellina <gi...@git.apache.org> on 2016/06/14 13:38:40 UTC
[GitHub] storm pull request #1486: STORM-1890: ensure static UI resources are re-requ...
GitHub user abellina opened a pull request:
https://github.com/apache/storm/pull/1486
STORM-1890: ensure static UI resources are re-requested with differen\u2026
\u2026t Storm package builds
Note it doesn't perform cache busting for logviewer. That is creating its own HTML, where I think it can be refactored to use some static file in public/, that is a separate task.
Thanks! I'll backport to 1.x if this looks good.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abellina/storm STORM-1890_ensure_we_refetch_static_resources_after_package_build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1486
----
commit 76a5e72e7cbdf9d9b32f5683d2bf5054ec0e2291
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Date: 2016-06-14T12:39:45Z
STORM-1890: ensure static UI resources are re-requested with different Storm package builds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1486: STORM-1890: ensure static UI resources are re-requested w...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/1486
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1486: STORM-1890: ensure static UI resources are re-requested w...
Posted by abellina <gi...@git.apache.org>.
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1486
I am going to close this and will re-open with some changes to add special not-caching headers for files like index.html or topology.html. While testing this for the 1.x branch I realized those files have the same issue, but you can't use cache busting there. So we need to ensure ring adds the no-cache headers for .html files that we serve.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1486: STORM-1890: ensure static UI resources are re-requ...
Posted by abellina <gi...@git.apache.org>.
Github user abellina closed the pull request at:
https://github.com/apache/storm/pull/1486
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1486: STORM-1890: ensure static UI resources are re-requested w...
Posted by abellina <gi...@git.apache.org>.
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1486
Build errors are unrelated to change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---