You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by PuspenduBanerjee <gi...@git.apache.org> on 2016/02/16 09:24:13 UTC

[GitHub] nifi pull request: Fix Nifi-1501 : Test Monitor Activity has spuri...

GitHub user PuspenduBanerjee opened a pull request:

    https://github.com/apache/nifi/pull/225

    Fix Nifi-1501 : Test Monitor Activity has spurious failures.

    Added test support with adaptive threshold to cater the assumption that  MonitorActivity shouldn't generate inactivity,  b/c run() will reset the lastSuccessfulTransfer.
    But that is only true if @OnSchedule & onTrigger  does not  get called more than MonitorActivity.THRESHOLD apart. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PuspenduBanerjee/nifi NiFi-1501

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #225
    
----
commit 4660ea1ddbee75ff7ad8df9b383f13a08f03b288
Author: puspendu.banerjee@gmail.com <pu...@gmail.com>
Date:   2016-02-16T08:00:08Z

    Fix Nifi-1501 : Test Monitor Activity has spurious failures.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: Fix NiFi-1501 : Test Monitor Activity has spuri...

Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:

    https://github.com/apache/nifi/pull/225#issuecomment-185025159
  
    BTW.. is there any way to comment or ask question on Extention Registry page at cwiki, seems I don't have access to comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: Fix NiFi-1501 : Test Monitor Activity has spuri...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/225


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: Fix Nifi-1501 : Test Monitor Activity has spuri...

Posted by PuspenduBanerjee <gi...@git.apache.org>.
Github user PuspenduBanerjee commented on the pull request:

    https://github.com/apache/nifi/pull/225#issuecomment-184942046
  
    Hi Team,
    Did anyone get a chance to review yet?
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: Fix NiFi-1501 : Test Monitor Activity has spuri...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:

    https://github.com/apache/nifi/pull/225#issuecomment-184965487
  
    not yet but that Travis-CI likes it is a good sign.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: Fix NiFi-1501 : Test Monitor Activity has spuri...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:

    https://github.com/apache/nifi/pull/225#issuecomment-185230292
  
    @PuspenduBanerjee i will add you now as a contributor to the apache nifi wiki so you can do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: Fix NiFi-1501 : Test Monitor Activity has spuri...

Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:

    https://github.com/apache/nifi/pull/225#issuecomment-185514088
  
    reviewing now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---