You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/19 21:09:26 UTC
[GitHub] [hive] granthenke opened a new pull request #1997: HIVE-24522: Support the Kudu DATE and VARCHAR column type
granthenke opened a new pull request #1997:
URL: https://github.com/apache/hive/pull/1997
This patch updates the Kudu version to the latest and adds
support for the new DATE and VARCHAR column types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] okumin commented on a change in pull request #1997: HIVE-24522: Support the Kudu DATE and VARCHAR column type
Posted by GitBox <gi...@apache.org>.
okumin commented on a change in pull request #1997:
URL: https://github.com/apache/hive/pull/1997#discussion_r579687008
##########
File path: kudu-handler/src/java/org/apache/hadoop/hive/kudu/KuduHiveUtils.java
##########
@@ -139,6 +141,8 @@ public static PrimitiveTypeInfo toHiveType(Type kuduType, ColumnTypeAttributes a
return TypeInfoFactory.doubleTypeInfo;
case STRING:
return TypeInfoFactory.stringTypeInfo;
+ case VARCHAR:
+ return TypeInfoFactory.getVarcharTypeInfo(attributes.getLength());
Review comment:
nit: indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on pull request #1997: HIVE-24522: Support the Kudu DATE and VARCHAR column type
Posted by GitBox <gi...@apache.org>.
jcamachor commented on pull request #1997:
URL: https://github.com/apache/hive/pull/1997#issuecomment-783585776
@granthenke , there seem to be some relevant test failures. Could you address those? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1997: HIVE-24522: Support the Kudu DATE and VARCHAR column type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1997:
URL: https://github.com/apache/hive/pull/1997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] granthenke commented on pull request #1997: HIVE-24522: Support the Kudu DATE and VARCHAR column type
Posted by GitBox <gi...@apache.org>.
granthenke commented on pull request #1997:
URL: https://github.com/apache/hive/pull/1997#issuecomment-783593303
@jcamachor I took a brief look this morning and couldn't find enough logs to get to the bottom of the issues. I can't reproduce locally, I suspect the issue is something related to using the kudu MiniCluster on the CI infra.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1997: HIVE-24522: Support the Kudu DATE and VARCHAR column type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1997:
URL: https://github.com/apache/hive/pull/1997#issuecomment-855489252
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org