You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/03/04 01:44:48 UTC
[GitHub] [groovy] paulk-asert commented on a change in pull request #886:
Groovy 8180 log to file
paulk-asert commented on a change in pull request #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886#discussion_r261902762
##########
File path: subprojects/groovy-console/src/main/groovy/groovy/ui/ConsolePreferences.groovy
##########
@@ -63,26 +64,36 @@ class ConsolePreferences {
title: T['prefs.dialog.title'], owner: console.frame, modal: true
) {
vbox {
- hbox(border: titledBorder(T['prefs.output.settings.title'])) {
- label "${T['prefs.max.characters.output']}:"
-
- formattedTextField value: maxOutputChars, id: 'txtMaxOutputChars',
- text:
- bind(target: this, targetProperty: 'maxOutputChars',
- validator: this.&isInteger, converter: Integer.&parseInt),
- columns: 6
+ vbox(border: titledBorder(T['prefs.output.settings.title'])) {
+ hbox {
+ label "${T['prefs.max.characters.output']}:"
+
+ formattedTextField value: maxOutputChars, id: 'txtMaxOutputChars',
+ text:
+ bind(target: this, targetProperty: 'maxOutputChars',
+ validator: this.&isInteger, converter: Integer.&parseInt),
+ columns: 6
+ }
+
+ hbox {
+ checkBox T['prefs.output.file'], id: 'outputFileCheckBox', selected: false
+ hglue()
+ button T['prefs.output.file.name'], id: 'outputFileName',
+ enabled: bind(source: outputFileCheckBox, sourceProperty: 'selected'),
+ actionPerformed: this.&onChooseFile
+ }
}
- vglue()
-
hbox {
button T['prefs.reset.defaults'], id: 'resetPrefsButton', actionPerformed: this.&onReset
hglue()
button T['prefs.close'], id: 'closePrefsButton', actionPerformed: this.&onClose
}
+
}
}
+ //console.swing.outputFileName.enabled = false
Review comment:
should this be deleted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services