You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2017/05/31 09:51:22 UTC
[GitHub] tinkerpop pull request #617: TINKERPOP-1681 Multiple hasId's are or'd into G...
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/617
TINKERPOP-1681 Multiple hasId's are or'd into GraphStep
https://issues.apache.org/jira/browse/TINKERPOP-1681
Fixed folding of multiple `hasId()`'s into `GraphStep`.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1681
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 063118e9d7b65cff82e74c5db47e64524a833e92
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2017-05-28T13:41:34Z
Fixed folding of multiple `hasId()` into `GraphStep`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #617: TINKERPOP-1681 Multiple hasId's are or'd into GraphSte...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/617
Seems right to me. Just to be certain `x.y.z` are ANDs and before, for `hasLabel()` and `hasId()` they were being OR'd. Test cases make sense.
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #617: TINKERPOP-1681 Multiple hasId's are or'd into GraphSte...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/617
Needs an entry to CHANGELOG, but all tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #617: TINKERPOP-1681 Multiple hasId's are or'd into G...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/617
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---