You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/08 20:55:03 UTC

[GitHub] [spark] xinrong-databricks opened a new pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

xinrong-databricks opened a new pull request #33938:
URL: https://github.com/apache/spark/pull/33938


   ### What changes were proposed in this pull request?
   Fix dropping all columns of a DataFrame
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes.
   
   From
   ```py
   >>> psdf = ps.DataFrame({"x": [1, 2], "y": [3, 4], "z": [5, 6]})
   >>> psdf
      x  y  z
   0  1  3  5
   1  2  4  6
   
   >>> psdf.drop(['x', 'y', 'z'])
   Traceback (most recent call last):
   ...
   ValueError: not enough values to unpack (expected 2, got 0)
   
   ```
   To
   ```py
   >>> psdf = ps.DataFrame({"x": [1, 2], "y": [3, 4], "z": [5, 6]})
   >>> psdf
      x  y  z
   0  1  3  5
   1  2  4  6
   
   >>> psdf.drop(['x', 'y', 'z'])
   Empty DataFrame
   Columns: []
   Index: [0, 1]
   ```
   
   
   ### How was this patch tested?
   Unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915611777


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47596/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915600896


   **[Test build #143094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143094/testReport)** for PR 33938 at commit [`869a3fd`](https://github.com/apache/spark/commit/869a3fde2a0503986d7e57d49b867099811a2671).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33938:
URL: https://github.com/apache/spark/pull/33938


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915614157


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47597/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915676927


   Merged to master and branch-3.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915567698


   CC @ueshin @HyukjinKwon @itholic 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915610084


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47597/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915616456






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915590481


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47596/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915586866


   **[Test build #143094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143094/testReport)** for PR 33938 at commit [`869a3fd`](https://github.com/apache/spark/commit/869a3fde2a0503986d7e57d49b867099811a2671).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915601220






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915586866


   **[Test build #143094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143094/testReport)** for PR 33938 at commit [`869a3fd`](https://github.com/apache/spark/commit/869a3fde2a0503986d7e57d49b867099811a2671).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33938: [SPARK-36697][PYTHON] Fix dropping all columns of a DataFrame

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33938:
URL: https://github.com/apache/spark/pull/33938#issuecomment-915601220


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143094/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org