[jira] Assigned: (SM-1740) remove unreachable code from JbiInInterceptor

["Freeman Fang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/SM-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang reassigned SM-1740:
--------------------------------

    Assignee: Freeman Fang

> remove unreachable code from JbiInInterceptor
> ---------------------------------------------
>
>                 Key: SM-1740
>                 URL: https://issues.apache.org/activemq/browse/SM-1740
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-cxf-bc
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>             Fix For: servicemix-cxf-bc-2008.02, 3.3.1, 3.2.4
>
>
> In the createExchange method of JbiInInterceptor
> we have code like
>            if (operation.getOutput() == null) {
>                 if (operation.getFaults().size() == 0) {
>                     mep = MessageExchangeSupport.IN_ONLY;
>                 } else {
>                     mep = MessageExchangeSupport.ROBUST_IN_ONLY;
>                 }
>             } else {
>                 mep = MessageExchangeSupport.IN_OUT;
>             }
> but actually when operation.getOutput() == null (which means it's oneway), per wsdl spec, the operation.getFaults().size() should always be 0, so 
>               else {
>                     mep = MessageExchangeSupport.ROBUST_IN_ONLY;
>                 }
> is unreachable.
> We need remove it and actully from cxf, there is no concept of ROBUST_IN_ONLY, only IN_ONLY and IN_OUT is supported

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.