You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/08 07:42:43 UTC
[GitHub] [skywalking] codecov-io commented on issue #4462: [Agent Core]
Support lazy ContextCarrier injection and lazy peer id setting
codecov-io commented on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting
URL: https://github.com/apache/skywalking/pull/4462#issuecomment-596176455
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=h1) Report
> Merging [#4462](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0439dccc3054a342d92a160f4e60352eba9ce4e5?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `51.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4462 +/- ##
==========================================
- Coverage 24.97% 24.97% -0.01%
==========================================
Files 1230 1231 +1
Lines 28490 28504 +14
Branches 3906 3907 +1
==========================================
+ Hits 7115 7118 +3
- Misses 20718 20727 +9
- Partials 657 659 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4462/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/context/trace/NoopExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4462/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wRXhpdFNwYW4uamF2YQ==) | `0% <0%> (ø)` | |
| [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4462/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `68.96% <0%> (-2.47%)` | :arrow_down: |
| [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4462/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <25%> (ø)` | :arrow_up: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4462/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `60.6% <62.5%> (-1.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=footer). Last update [0439dcc...3be6195](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services