You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 20:19:04 UTC
[GitHub] [arrow] tachyonwill opened a new pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
tachyonwill opened a new pull request #12488:
URL: https://github.com/apache/arrow/pull/12488
SetListData in array_nested.cc has a DCHECK that the map type matches
the type of the child struct. When a Parquet file has a non-standard
field name for a map key(not "key"), the struct would have the alternate
name whereas the maptype would not, triggering the DCHECK. The fix is to
call the appropriate MapType constructor so the key field name is
preserved. This is very similar to ARROW-13735.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1059557562
Benchmark runs are scheduled for baseline = 762bb3d64f055db72ebb61ebe0d53a929ea8cd34 and contender = 348057aea798bf612eddcae42495234e5853fd76. 348057aea798bf612eddcae42495234e5853fd76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6c102c39458a441396b825c2399cadeb...257cfdd8f51f4bfc9c7557a15fb6a976/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4f0376a20cc64069985faf0051cdd183...fe22a44f89094358834732e9c61024c2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cf73570ffd8f4728ab6254b5e1714153...12ac3378939e463c87c6c5bb6942f83c/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a6866644070240488813653b69998d40...24ebc8c6fca9455398058eaba491f615/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1059557562
Benchmark runs are scheduled for baseline = 762bb3d64f055db72ebb61ebe0d53a929ea8cd34 and contender = 348057aea798bf612eddcae42495234e5853fd76. 348057aea798bf612eddcae42495234e5853fd76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6c102c39458a441396b825c2399cadeb...257cfdd8f51f4bfc9c7557a15fb6a976/)
[Finished :arrow_down:1.13% :arrow_up:0.88%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4f0376a20cc64069985faf0051cdd183...fe22a44f89094358834732e9c61024c2/)
[Finished :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cf73570ffd8f4728ab6254b5e1714153...12ac3378939e463c87c6c5bb6942f83c/)
[Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a6866644070240488813653b69998d40...24ebc8c6fca9455398058eaba491f615/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1059557562
Benchmark runs are scheduled for baseline = 762bb3d64f055db72ebb61ebe0d53a929ea8cd34 and contender = 348057aea798bf612eddcae42495234e5853fd76. 348057aea798bf612eddcae42495234e5853fd76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6c102c39458a441396b825c2399cadeb...257cfdd8f51f4bfc9c7557a15fb6a976/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4f0376a20cc64069985faf0051cdd183...fe22a44f89094358834732e9c61024c2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cf73570ffd8f4728ab6254b5e1714153...12ac3378939e463c87c6c5bb6942f83c/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a6866644070240488813653b69998d40...24ebc8c6fca9455398058eaba491f615/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1048177652
https://issues.apache.org/jira/browse/PARQUET-2130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1059557562
Benchmark runs are scheduled for baseline = 762bb3d64f055db72ebb61ebe0d53a929ea8cd34 and contender = 348057aea798bf612eddcae42495234e5853fd76. 348057aea798bf612eddcae42495234e5853fd76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6c102c39458a441396b825c2399cadeb...257cfdd8f51f4bfc9c7557a15fb6a976/)
[Finished :arrow_down:1.13% :arrow_up:0.88%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4f0376a20cc64069985faf0051cdd183...fe22a44f89094358834732e9c61024c2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cf73570ffd8f4728ab6254b5e1714153...12ac3378939e463c87c6c5bb6942f83c/)
[Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a6866644070240488813653b69998d40...24ebc8c6fca9455398058eaba491f615/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1059557562
Benchmark runs are scheduled for baseline = 762bb3d64f055db72ebb61ebe0d53a929ea8cd34 and contender = 348057aea798bf612eddcae42495234e5853fd76. 348057aea798bf612eddcae42495234e5853fd76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6c102c39458a441396b825c2399cadeb...257cfdd8f51f4bfc9c7557a15fb6a976/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4f0376a20cc64069985faf0051cdd183...fe22a44f89094358834732e9c61024c2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cf73570ffd8f4728ab6254b5e1714153...12ac3378939e463c87c6c5bb6942f83c/)
[Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a6866644070240488813653b69998d40...24ebc8c6fca9455398058eaba491f615/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield closed pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #12488:
URL: https://github.com/apache/arrow/pull/12488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tachyonwill commented on pull request #12488: PARQUET-2130: Fix crash in debug with non-standard key names.
Posted by GitBox <gi...@apache.org>.
tachyonwill commented on pull request #12488:
URL: https://github.com/apache/arrow/pull/12488#issuecomment-1048179463
PR for the fuzzer created file that uncovered this issue, https://github.com/apache/arrow-testing/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org