You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/04/01 10:29:45 UTC

Review Request 45578: Add visibility attribute into SCRIPT params

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45578/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.


Bugs: AMBARI-15666
    https://issues.apache.org/jira/browse/AMBARI-15666


Repository: ambari


Description
-------

As discussed...Need an attribute "visibility" that can optionally be included in SCRIPT params.

1) If omitted, the param is shown in the UI
2) If set "visibility":"hidden", the param is hidden in the UI
3) If set "visibility":"readonly", the param is shown in the UI but not edtiable

{code}
"parameters": [
{
"name": "connection.timeout",
"display_name": "Connection Timeout",
"value": 5.0,
"type": "NUMERIC",
"description": "The maximum time before this alert is considered to be CRITICAL",
"units": "seconds",
"threshold": "CRITICAL"
},
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java f67a135 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java d8b84ec 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py 9521d61 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json fc3e21f 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 2ff7069 

Diff: https://reviews.apache.org/r/45578/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 45578: Add visibility attribute into SCRIPT params

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45578/#review126565
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 1, 2016, 8:29 до полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45578/
> -----------------------------------------------------------
> 
> (Updated Квітень 1, 2016, 8:29 до полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15666
>     https://issues.apache.org/jira/browse/AMBARI-15666
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As discussed...Need an attribute "visibility" that can optionally be included in SCRIPT params.
> 
> 1) If omitted, the param is shown in the UI
> 2) If set "visibility":"hidden", the param is hidden in the UI
> 3) If set "visibility":"readonly", the param is shown in the UI but not edtiable
> 
> {code}
> "parameters": [
> {
> "name": "connection.timeout",
> "display_name": "Connection Timeout",
> "value": 5.0,
> "type": "NUMERIC",
> "description": "The maximum time before this alert is considered to be CRITICAL",
> "units": "seconds",
> "threshold": "CRITICAL"
> },
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java f67a135 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java d8b84ec 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 9521d61 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json fc3e21f 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 2ff7069 
> 
> Diff: https://reviews.apache.org/r/45578/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 45578: Add visibility attribute into SCRIPT params

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45578/#review126566
-----------------------------------------------------------


Ship it!




As long as UT pass +1

- Andrew Onischuk


On April 1, 2016, 8:29 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45578/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 8:29 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15666
>     https://issues.apache.org/jira/browse/AMBARI-15666
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As discussed...Need an attribute "visibility" that can optionally be included in SCRIPT params.
> 
> 1) If omitted, the param is shown in the UI
> 2) If set "visibility":"hidden", the param is hidden in the UI
> 3) If set "visibility":"readonly", the param is shown in the UI but not edtiable
> 
> {code}
> "parameters": [
> {
> "name": "connection.timeout",
> "display_name": "Connection Timeout",
> "value": 5.0,
> "type": "NUMERIC",
> "description": "The maximum time before this alert is considered to be CRITICAL",
> "units": "seconds",
> "threshold": "CRITICAL"
> },
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java f67a135 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java d8b84ec 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 9521d61 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json fc3e21f 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 2ff7069 
> 
> Diff: https://reviews.apache.org/r/45578/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>