You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/25 01:29:22 UTC

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2393: feat: Adding view buttons to the plugin-template page

guoqqqi commented on a change in pull request #2393:
URL: https://github.com/apache/apisix-dashboard/pull/2393#discussion_r834877485



##########
File path: web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -77,6 +78,19 @@ context('Create Configure and Delete PluginTemplate', () => {
     cy.contains('Submit').click();
     cy.get(selector.notification).should('contain', data.createPluginTemplateSuccess);
   });
+  it('should view the service', function () {

Review comment:
       ```suggestion
     it('should view the plugin template', function () {
   ```

##########
File path: web/src/pages/PluginTemplate/List.tsx
##########
@@ -22,13 +22,19 @@ import type { ActionType, ProColumns } from '@ant-design/pro-table';
 import { Button, notification, Popconfirm, Select, Space, Tag } from 'antd';
 import { PlusOutlined } from '@ant-design/icons';
 import usePagination from '@/hooks/usePagination';
-import { fetchList, remove, fetchLabelList } from './service';
+import { fetchList, remove, create, fetchLabelList, update } from './service';
+import { RawDataEditor } from '@/components/RawDataEditor';
+import { omit } from 'lodash';

Review comment:
       Move this line to line 25




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org