You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/04 10:59:11 UTC
[GitHub] [spark] LuciferYang opened a new pull request #30247: [SPARK-33341][CORE][SQL]Remove unnecessary semicolons in Scala code
LuciferYang opened a new pull request #30247:
URL: https://github.com/apache/spark/pull/30247
### What changes were proposed in this pull request?
There are some unnecessary semicolons in Spark code because Scala doesn't really need them and most spark code also doesn't use it to split clauses, so this pr clear them globally.
### Why are the changes needed?
Remove unnecessary semicolons to unify the code style
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721736877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721682635
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35199/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721664117
**[Test build #130598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130598/testReport)** for PR 30247 at commit [`56c3553`](https://github.com/apache/spark/commit/56c35534b4a6ad9e86cab3b4798ebdc5eddfa21b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721736877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721692062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30247:
URL: https://github.com/apache/spark/pull/30247#discussion_r517315456
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -59,7 +59,7 @@ class HistoryServer(
private val retainedApplications = conf.get(History.RETAINED_APPLICATIONS)
// How many applications the summary ui displays
- private[history] val maxApplications = conf.get(HISTORY_UI_MAX_APPS);
+ private[history] val maxApplications = conf.get(HISTORY_UI_MAX_APPS)
Review comment:
Does this show any warnings? If not, let's don't do this. It will make difficult to maintain e.g.) backporting or revert but the gain is just cosmetic stuffs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721692041
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35199/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721735698
**[Test build #130598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130598/testReport)** for PR 30247 at commit [`56c3553`](https://github.com/apache/spark/commit/56c35534b4a6ad9e86cab3b4798ebdc5eddfa21b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30247: [SPARK-33341][CORE][SQL]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721664117
**[Test build #130598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130598/testReport)** for PR 30247 at commit [`56c3553`](https://github.com/apache/spark/commit/56c35534b4a6ad9e86cab3b4798ebdc5eddfa21b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721692062
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30247:
URL: https://github.com/apache/spark/pull/30247#issuecomment-721692069
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35199/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org