You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2018/08/29 15:37:39 UTC

[GitHub] nifi pull request #2974: NIFI-5533: Be more efficient with heap utilization

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2974

    NIFI-5533: Be more efficient with heap utilization

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5533

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2974
    
----
commit 35297268ef90e83385c7487b17100e41ccc22340
Author: Mark Payne <ma...@...>
Date:   2018-08-17T18:08:14Z

    NIFI-5533: Be more efficient with heap utilization
     - Updated FlowFile Repo / Write Ahead Log so that any update that writes more than 1 MB of data is written to a file inside the FlowFile Repo rather than being buffered in memory
     - Update SplitText so that it does not hold FlowFiles that are not the latest version in heap. Doing them from being garbage collected, so while the Process Session is holding the latest version of the FlowFile, SplitText is holding an older version, and this results in two copies of the same FlowFile object

commit 45d3ab2ad166b5df573adbfab2f5e8be9efc8705
Author: Mark Payne <ma...@...>
Date:   2018-08-23T16:58:59Z

    NIFI-5533: Checkpoint

commit bd866a1652e671a62f71233ced160f0a215f7a5f
Author: Mark Payne <ma...@...>
Date:   2018-08-23T17:55:25Z

    NIFI-5533: Bug Fixes

----


---

[GitHub] nifi issue #2974: NIFI-5533: Be more efficient with heap utilization

Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/2974
  
    +1 LGTM, ran full build with unit tests and tried many different scenarios with record processors, attributes, etc. Thanks for the improvements! Merging to master


---

[GitHub] nifi pull request #2974: NIFI-5533: Be more efficient with heap utilization

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2974


---