You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2020/03/31 15:16:00 UTC
[jira] [Commented] (SLING-9313) Content Package Installer: do not
return an InstallTask if the TaskResource is of an unsupported type
[ https://issues.apache.org/jira/browse/SLING-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071879#comment-17071879 ]
Konrad Windszus commented on SLING-9313:
----------------------------------------
Indeed, this is a regression of https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/02630994754015433237b6e4221132587a39a8ec.
> Content Package Installer: do not return an InstallTask if the TaskResource is of an unsupported type
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-9313
> URL: https://issues.apache.org/jira/browse/SLING-9313
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Packages Factory 1.0.0
> Reporter: Radu Cotescu
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: Installer Packages Factory 1.0.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{org.apache.sling.installer.factory.packages.impl.PackageTransformer#createTask}} currently returns a {{ChangeStateTask}} for resources that it cannot handle [0]. According to the documentation of the {{org.apache.sling.installer.api.tasks.InstallTaskFactory}}, a factory should return {{null}} "if the factory does not support the resource".
> The following error is encountered in the HTL integration tests setup from https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing:
> {noformat}
> 31.03.2020 16:15:14.833 *ERROR* [OsgiInstallerImpl] org.apache.sling.installer.factory.packages.impl.PackageTransformer Unupported type of TaskResource(url=jcrinstall:/apps/sightly/install/org.apache.sling.scripting.sightly.testing-content-crlf.jar, entity=bundle:org.apache.sling.scripting.sightly.testing-content-crlf, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:448:611:9:, Bundle-SymbolicName=org.apache.sling.scripting.sightly.testing-content-crlf, Bundle-Version=1.0.0], digest=1585265891708): bundle.
> {noformat}
> Several tests are failing, since the above bundle doesn't get installed. The error cannot be reproduced all the time, suggesting that the order in which the {{org.apache.sling.installer.api.tasks.InstallTaskFactory}} services are started plays a role.
> [0] - https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/org.apache.sling.installer.factory.packages-1.0.0/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L241
--
This message was sent by Atlassian Jira
(v8.3.4#803005)